From 59147be9aeea47576884e5587dd7da8bb58c6c53 Mon Sep 17 00:00:00 2001 From: Alexandre Oliva Date: Tue, 17 Sep 2013 04:23:32 -0300 Subject: [PATCH] osd: compute full ratio from kb_avail On btrfs, kb_used + kb_avail can be much smaller than total kb, and what really matters to avoid filling up the disk is how much space is available, not how much we've used. Thus, compute the ratio we use to determine full or nearfull from kb_avail rather than from kb_used. Signed-off-by: Alexandre Oliva Signed-off-by: Sage Weil --- src/osd/OSD.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 20aef0301ec97..76bdb02c0adfd 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -2541,7 +2541,12 @@ void OSDService::check_nearfull_warning(const osd_stat_t &osd_stat) time_t now = ceph_clock_gettime(NULL); - float ratio = ((float)osd_stat.kb_used) / ((float)osd_stat.kb); + // We base ratio on kb_avail rather than kb_used because they can + // differ significantly e.g. on btrfs volumes with a large number of + // chunks reserved for metadata, and for our purposes (avoiding + // completely filling the disk) it's far more important to know how + // much space is available to use than how much we've already used. + float ratio = ((float)(osd_stat.kb - osd_stat.kb_avail)) / ((float)osd_stat.kb); float nearfull_ratio = get_nearfull_ratio(); float full_ratio = get_full_ratio(); cur_ratio = ratio; -- 2.39.5