From 591d9654100dac3870eccab51b5df7e02052843a Mon Sep 17 00:00:00 2001 From: Yingxin Cheng Date: Mon, 26 Apr 2021 14:44:54 +0800 Subject: [PATCH] crimson/seastore: make OnodeManager interfaces pure virtual Signed-off-by: Yingxin Cheng --- src/crimson/os/seastore/onode_manager.h | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/crimson/os/seastore/onode_manager.h b/src/crimson/os/seastore/onode_manager.h index 5031afd33dc..c08cd44cd06 100644 --- a/src/crimson/os/seastore/onode_manager.h +++ b/src/crimson/os/seastore/onode_manager.h @@ -33,9 +33,7 @@ public: OnodeRef>; virtual get_onode_ret get_onode( Transaction &trans, - const ghobject_t &hoid) { - return seastar::make_ready_future(); - } + const ghobject_t &hoid) = 0; using get_or_create_onode_ertr = base_ertr::extend< crimson::ct_error::value_too_large>; @@ -43,9 +41,7 @@ public: OnodeRef>; virtual get_or_create_onode_ret get_or_create_onode( Transaction &trans, - const ghobject_t &hoid) { - return seastar::make_ready_future(); - } + const ghobject_t &hoid) = 0; using get_or_create_onodes_ertr = base_ertr::extend< crimson::ct_error::value_too_large>; @@ -53,17 +49,14 @@ public: std::vector>; virtual get_or_create_onodes_ret get_or_create_onodes( Transaction &trans, - const std::vector &hoids) { - return seastar::make_ready_future>(); - } + const std::vector &hoids) = 0; using write_dirty_ertr = base_ertr; using write_dirty_ret = write_dirty_ertr::future<>; virtual write_dirty_ret write_dirty( Transaction &trans, - const std::vector &onodes) { - return seastar::now(); - } + const std::vector &onodes) = 0; + virtual ~OnodeManager() {} }; using OnodeManagerRef = std::unique_ptr; -- 2.39.5