From 59ff572fd6b0e331635a710769b02332bdb982dc Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Sat, 1 Mar 2014 13:54:53 -0800 Subject: [PATCH] OpTracker: clarify that unregister_inflight_op is only called if enabled The !tracking_enabled branch actually had a leak which was unreachable since the caller does the check for tracking_enabled. Signed-off-by: Samuel Just --- src/common/TrackedOp.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/TrackedOp.cc b/src/common/TrackedOp.cc index a1abf9ff1025b..9e83c0b74b6c8 100644 --- a/src/common/TrackedOp.cc +++ b/src/common/TrackedOp.cc @@ -118,10 +118,10 @@ void OpTracker::register_inflight_op(xlist::item *i) void OpTracker::unregister_inflight_op(TrackedOp *i) { + // caller checks; + assert(tracking_enabled); i->request->clear_data(); - if (!tracking_enabled) - return; Mutex::Locker locker(ops_in_flight_lock); assert(i->xitem.get_list() == &ops_in_flight); -- 2.39.5