From 5a9d6c080d77c7e3644b02cab4f8c91900f4fe8f Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Mon, 29 Mar 2021 20:07:25 -0700 Subject: [PATCH] mds: remove extra heap release We now regularly do this unconditionally in the MDS, see the upkeep thread. Signed-off-by: Patrick Donnelly --- src/mds/MDCache.cc | 18 ------------------ src/mds/MDCache.h | 1 - 2 files changed, 19 deletions(-) diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc index e12e6942d35..d48db912819 100644 --- a/src/mds/MDCache.cc +++ b/src/mds/MDCache.cc @@ -320,10 +320,6 @@ void MDCache::add_inode(CInode *in) if (in->is_base()) base_inodes.insert(in); } - - if (cache_toofull()) { - exceeded_size_limit = true; - } } void MDCache::remove_inode(CInode *o) @@ -7739,20 +7735,6 @@ void MDCache::check_memory_usage() if (cache_toofull()) { mds->server->recall_client_state(nullptr, Server::RecallFlags::TRIM); } - - // If the cache size had exceeded its limit, but we're back in bounds - // now, free any unused pool memory so that our memory usage isn't - // permanently bloated. - if (exceeded_size_limit && !cache_toofull()) { - // Only do this once we are back in bounds: otherwise the releases would - // slow down whatever process caused us to exceed bounds to begin with - if (ceph_using_tcmalloc()) { - dout(5) << "check_memory_usage: releasing unused space from tcmalloc" - << dendl; - ceph_heap_release_free_memory(); - } - exceeded_size_limit = false; - } } diff --git a/src/mds/MDCache.h b/src/mds/MDCache.h index 5c837d620c5..d59d406751b 100644 --- a/src/mds/MDCache.h +++ b/src/mds/MDCache.h @@ -1143,7 +1143,6 @@ class MDCache { std::unique_ptr logger; Filer filer; - bool exceeded_size_limit = false; std::array, client_lease_pools> client_leases{}; /* subtree keys and each tree's non-recursive nested subtrees (the "bounds") */ -- 2.39.5