From 5ba5fbf3058e044381091c49d821b36337389c4a Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Sun, 28 Oct 2018 20:21:53 -0500 Subject: [PATCH] osd: fix heartbeat_reset unlock Fixes 51d8e2457d73c709bfa4f706793696b3ce704ff9, which moved to lock_guard but didn't remove the unlock call on this exit path. Signed-off-by: Sage Weil (cherry picked from commit 1a0e2f7e1518d57bc07176f4297315a7c9a3c139) --- src/osd/OSD.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 265224775a189..1fb8ca036c0f6 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -4760,7 +4760,6 @@ bool OSD::heartbeat_reset(Connection *con) auto s = con->get_priv(); if (s) { if (is_stopping()) { - heartbeat_lock.Unlock(); return true; } auto heartbeat_session = static_cast(s.get()); -- 2.39.5