From 5c243ca419528d2846d25a55a8dc3751fceae04f Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 14 Apr 2021 11:21:42 +0800 Subject: [PATCH] msg/Message: use an unsigned type for get_data_len() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit to avoid warnings like: ../src/osd/PrimaryLogPG.cc:2123:27: warning: comparison of integer expressions of different signedness: ‘off_t’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare] 2123 | m->get_data_len() > cct->_conf->osd_max_write_size << 20) { | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ after change the size options' type to unsigned or uint64_t. Signed-off-by: Kefu Chai --- src/msg/Message.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/msg/Message.h b/src/msg/Message.h index 8e1c4f967f0..870ad0781c3 100644 --- a/src/msg/Message.h +++ b/src/msg/Message.h @@ -430,7 +430,7 @@ public: byte_throttler->put(data.length()); bl = std::move(data); } - off_t get_data_len() const { return data.length(); } + uint32_t get_data_len() const { return data.length(); } void set_recv_stamp(utime_t t) { recv_stamp = t; } const utime_t& get_recv_stamp() const { return recv_stamp; } -- 2.39.5