From 5ca4881dbb8b09429e2a8c4a63da3d2c0e17cac8 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 31 Jul 2019 14:29:24 +0800 Subject: [PATCH] test/python: remove test for ceph cli we have abundant test for exercising `ceph` cli, like qa/standalone/mon/misc.sh. and `test_ceph.py` does not test any functionality of this python script other than importing it, which basically runs it through python's syntax check. Signed-off-by: Kefu Chai --- src/test/python/.gitignore | 27 ------------------------- src/test/python/ceph/.gitignore | 3 --- src/test/python/ceph/setup.py | 27 ------------------------- src/test/python/ceph/tests/test_ceph.py | 10 --------- src/test/python/ceph/tox.ini | 18 ----------------- 5 files changed, 85 deletions(-) delete mode 100644 src/test/python/.gitignore delete mode 100644 src/test/python/ceph/.gitignore delete mode 100644 src/test/python/ceph/setup.py delete mode 100644 src/test/python/ceph/tests/test_ceph.py delete mode 100644 src/test/python/ceph/tox.ini diff --git a/src/test/python/.gitignore b/src/test/python/.gitignore deleted file mode 100644 index f24cd9952da..00000000000 --- a/src/test/python/.gitignore +++ /dev/null @@ -1,27 +0,0 @@ -*.py[co] - -# Packages -*.egg -*.egg-info -dist -build -eggs -parts -bin -var -sdist -develop-eggs -.installed.cfg - -# Installer logs -pip-log.txt - -# Unit test / coverage reports -.coverage -.tox - -#Translations -*.mo - -#Mr Developer -.mr.developer.cfg diff --git a/src/test/python/ceph/.gitignore b/src/test/python/ceph/.gitignore deleted file mode 100644 index 88c7fe6f857..00000000000 --- a/src/test/python/ceph/.gitignore +++ /dev/null @@ -1,3 +0,0 @@ -# this is a generated file used for testing and symlinked and should be ignored -# as paths are absolute to the test machine -ceph.py diff --git a/src/test/python/ceph/setup.py b/src/test/python/ceph/setup.py deleted file mode 100644 index 90dbb59e242..00000000000 --- a/src/test/python/ceph/setup.py +++ /dev/null @@ -1,27 +0,0 @@ -import os -from setuptools import setup, find_packages - -# link ceph script here so we can "install" it -current_dir = os.path.abspath(os.path.dirname(__file__)) -src_dir = os.path.dirname(os.path.dirname(os.path.dirname(current_dir))) -script_path = os.path.join(src_dir, 'ceph.in') - - -def link_target(source, destination): - if not os.path.exists(destination): - try: - os.symlink(source, destination) - except (IOError, OSError) as error: - print('Ignoring linking of target: %s' % str(error)) - -link_target(script_path, 'ceph.py') - -setup( - name='ceph', - version='0.1', - description='', - author='', - author_email='', - zip_safe=False, - packages=find_packages(), -) diff --git a/src/test/python/ceph/tests/test_ceph.py b/src/test/python/ceph/tests/test_ceph.py deleted file mode 100644 index d26493ea11f..00000000000 --- a/src/test/python/ceph/tests/test_ceph.py +++ /dev/null @@ -1,10 +0,0 @@ -import ceph - -# This file tests nothing (yet) except for being able to import ceph -# correctly and thus ensuring somewhat that it will work under different Python -# versions. You must write unittests here so that code has adequate coverage. - -class TestCeph(object): - - def test_basic(self): - assert True diff --git a/src/test/python/ceph/tox.ini b/src/test/python/ceph/tox.ini deleted file mode 100644 index 6f28f577e9d..00000000000 --- a/src/test/python/ceph/tox.ini +++ /dev/null @@ -1,18 +0,0 @@ -[tox] -envlist = py26, py27, flake8 -skipsdist=True - -[testenv] -deps= - pytest -setenv = - PYTHONPATH = {toxinidir}/../../../pybind - -commands= - python setup.py develop - py.test -v - -[testenv:flake8] -deps= - flake8 -commands=flake8 --select=F ceph.py -- 2.39.5