From 5cb4c1cd3da796c64e51bce015bd45a585ab75e2 Mon Sep 17 00:00:00 2001 From: Dnyaneshwari Talwekar Date: Mon, 18 May 2026 12:25:14 +0530 Subject: [PATCH] mgr/dashboard: NFS enhancements - terminology alignment Fixes: https://tracker.ceph.com/issues/76655 Signed-off-by: Dnyaneshwari Talwekar --- .../nfs-cluster-details.component.html | 2 +- .../nfs-cluster-details.component.ts | 2 +- .../app/ceph/nfs/nfs-form/nfs-form.component.html | 14 +++++++------- .../app/ceph/nfs/nfs-form/nfs-form.component.ts | 2 +- .../app/ceph/nfs/nfs-list/nfs-list.component.ts | 2 +- .../src/app/shared/constants/app.constants.ts | 2 +- .../frontend/src/app/shared/enum/icons.enum.ts | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.html index eb6a1ef2b7f0..5605ae925120 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.html @@ -4,7 +4,7 @@ > {{title | titlecase}} - Lists exports for a cluster + Lists shares for a cluster diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.ts index f5d84e823d92..b3c23e017314 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-cluster-details/nfs-cluster-details.component.ts @@ -8,7 +8,7 @@ import { CdTableSelection } from '~/app/shared/models/cd-table-selection'; standalone: false }) export class NfsClusterDetailsComponent { - title = $localize`Export`; + title = $localize`Share`; @Input() selection: CdTableSelection; } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html index 0da4913e9b8a..b47afea18018 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html @@ -48,7 +48,7 @@ - +
This field is required. Export on CephFS volume "/" not allowed. + i18n>Share on CephFS volume "/" not allowed. Path need to start with a '/' and can be followed by a word @@ -315,8 +315,8 @@ [invalid]="nfsForm.controls.pseudo.invalid && (nfsForm.controls.pseudo.dirty)"> - The position this export occupies in the Pseudo FS. It must be unique.
- By using different Pseudo options, the same Path may be exported multiple times. + The position this share occupies in the Pseudo FS. It must be unique.
+ By using different Pseudo options, the same Path may be shared multiple times. This field is required. The pseudo is already in use by another export. + i18n>The pseudo is already in use by another share. Pseudo needs to start with a '/' and can't contain any of the following: >, <, |, &, ( or ). @@ -397,13 +397,13 @@ Maps the root user on the NFS client to an anonymous user/group with limited privileges. This prevents a root client user from having total control over the NFS export. + i18n>Maps the root user on the NFS client to an anonymous user/group with limited privileges. This prevents a root client user from having total control over the NFS share. Maps the root user on the NFS client to an anonymous user/group with limited privileges, preventing root access but retaining non-root group privileges. Maps all users on the NFS client to an anonymous user/group with limited privileges, ensuring that no user has special privileges on the NFS export. + i18n>Maps all users on the NFS client to an anonymous user/group with limited privileges, ensuring that no user has special privileges on the NFS share. Allows the root user on the NFS client to retain full root privileges on the NFS server, which may pose security risks. diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.ts index dee02d762c59..b4cd2840fdca 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.ts @@ -112,7 +112,7 @@ export class NfsFormComponent extends CdForm implements OnInit { ) { super(); this.permission = this.authStorageService.getPermissions().pool; - this.resource = $localize`NFS export`; + this.resource = $localize`NFS share`; this.storageBackend = getFsalFromRoute(this.router.url); } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-list/nfs-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-list/nfs-list.component.ts index 2bf3825bdd7b..7ddee926273c 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-list/nfs-list.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-list/nfs-list.component.ts @@ -237,7 +237,7 @@ export class NfsListComponent extends ListWithDetails implements OnInit, OnDestr this.modalRef = this.modalService.show(DeleteConfirmationModalComponent, { impact: DeletionImpact.high, - itemDescription: $localize`NFS export`, + itemDescription: $localize`NFS share`, itemNames: [`${cluster_id}:${export_id}`], submitActionObservable: () => this.taskWrapper.wrapTaskAroundCall({ diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts index 6d63dd9e9dcd..22673b0ac2d4 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts @@ -255,7 +255,7 @@ export class ActionLabelsI18n { this.RECONNECT = $localize`Reconnect`; this.ADD_STORAGE = $localize`Add Storage`; - this.NFS_EXPORT = $localize`Create NFS Export`; + this.NFS_EXPORT = $localize`Create NFS Share`; this.VIEW = $localize`View`; } } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/enum/icons.enum.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/enum/icons.enum.ts index ecf4715a5518..49bc33d87b30 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/enum/icons.enum.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/enum/icons.enum.ts @@ -79,7 +79,7 @@ export enum Icons { eye = 'fa fa-eye', // Observability calendar = 'fa fa-calendar', externalUrl = 'fa fa-external-link', // links to external page - nfsExport = 'fa fa-server', // NFS export + nfsExport = 'fa fa-server', // NFS share launch = 'launch', parentChild = 'parent-child', dataTable = 'data-table', -- 2.47.3