From 5d88b638ff4ad68f5ecce96d5d4d3a85fc4a2a5c Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Fri, 18 Oct 2013 16:23:14 +0000 Subject: [PATCH] xfstests: Test xfs_fsr / swapext management of di_forkoff w/ selinux In some cases selinux's creation of an xattr on the temporary fd creates a local xattr, but the file we are trying to defragment has attrs in extent format, and the forkoff mismatch will cause xfs_fsr to fail. This test demonstrates it; I have old patches sent to the list long ago that should fix it. I'll resend them soon. Signed-off-by: Eric Sandeen Reviewed-by: Eryu Guan Signed-off-by: Rich Johnston --- tests/xfs/300 | 88 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/300.out | 3 ++ tests/xfs/group | 1 + 3 files changed, 92 insertions(+) create mode 100755 tests/xfs/300 create mode 100644 tests/xfs/300.out diff --git a/tests/xfs/300 b/tests/xfs/300 new file mode 100755 index 00000000..0958f76a --- /dev/null +++ b/tests/xfs/300 @@ -0,0 +1,88 @@ +#! /bin/bash +# FS QA Test No. 300 +# +# Test xfs_fsr / swapext management of di_forkoff w/ selinux +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +_require_scratch + +# real QA test starts here + +_supported_fs xfs +_supported_os Linux + +getenforce | grep -q "Enforcing\|Permissive" || _notrun "SELinux not enabled" +[ "$XFS_FSR_PROG" = "" ] && _notrun "xfs_fsr not found" + +rm -f $seqres.full + +_scratch_mkfs_xfs -i size=256 >> $seq.full 2>&1 || _fail "mkfs failed" + +# Manually mount to avoid fs-wide context set by default in xfstests +mount $SCRATCH_DEV $SCRATCH_MNT + +touch $SCRATCH_MNT/$seq.test + +# Create an extents-format attribute on a file +$XFS_IO_PROG -f -c "pwrite -S 0x63 0 4096" $SCRATCH_MNT/attrvals >> $seqres.full 2>&1 +cat $SCRATCH_MNT/attrvals | attr -s name $SCRATCH_MNT/$seq.test >> $seqres.full 2>&1 + +# Fragment the file by writing backwards +for I in `seq 6 -1 0`; do + dd if=/dev/zero of=$SCRATCH_MNT/$seq.test seek=$I bs=4k \ + oflag=direct count=1 conv=notrunc >> $seqres.full 2>&1 +done + +# See if xfs_fsr works. + +# The target file now has a non-local attribute, but the +# fsr temp file gets assigned a local attribute on creation, +# due to selinux. + +# In this case, the large-ish selinux attr will create a forkoff +# in the temp file smaller than the forkoff in the target file, +# because the FMT_EXTENTS attr takes up less space. If there is +# no mechanism to grow the temp forkoff to match, we can end up +# failing to swap these 2 inodes if the result is not enough +# data space in the temp inode as a result. + +$XFS_FSR_PROG -v $SCRATCH_MNT/$seq.test | _filter_scratch + +# success, all done +status=0 +exit diff --git a/tests/xfs/300.out b/tests/xfs/300.out new file mode 100644 index 00000000..ac03557f --- /dev/null +++ b/tests/xfs/300.out @@ -0,0 +1,3 @@ +QA output created by 300 +SCRATCH_MNT/300.test +extents before:6 after:1 DONE SCRATCH_MNT/300.test diff --git a/tests/xfs/group b/tests/xfs/group index 17fff270..5eaa5e35 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -179,3 +179,4 @@ 297 auto freeze 298 auto attr symlink quick 299 auto quota +300 auto fsr -- 2.39.5