From 5d9896084eb572903723da5d003a9cda2f9a4ab1 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 10 Jan 2012 16:39:23 -0800 Subject: [PATCH] monclient: fix resolve_addrs() call This was broken in def36668a13459d9c0851e4d4da440a288f9a34f it looks like. Passing uninitialized memory to resolve_addrs(), and needlessly allocating a buffer. Signed-off-by: Sage Weil --- src/mon/MonClient.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mon/MonClient.cc b/src/mon/MonClient.cc index 1ea49dcdcb34a..38f07725d9cd3 100644 --- a/src/mon/MonClient.cc +++ b/src/mon/MonClient.cc @@ -120,9 +120,7 @@ int MonClient::build_initial_monmap(CephContext *cct, MonMap &monmap) return 0; } else { //maybe they passed us a DNS-resolvable name char *hosts = NULL; - char *old_addrs = new char[conf->mon_host.size() + 1]; - hosts = resolve_addrs(old_addrs); - delete [] old_addrs; + hosts = resolve_addrs(conf->mon_host.c_str()); if (!hosts) return -EINVAL; bool success = parse_ip_port_vec(hosts, addrs); -- 2.39.5