From 5f9cbd7089fe14f3d4ef9ce6ec08135d09e2e8e0 Mon Sep 17 00:00:00 2001 From: Zorro Lang Date: Mon, 27 Feb 2017 16:23:03 +0800 Subject: [PATCH] common/xfs: fix unexpected failure on real 4k sector device _xfs_mkfs_validation_check() run "$cmd -s size=2s" to be sure if xfsprogs support stricter input checks. But there's an unexpected failure on 4k sector device: # blockdev --getbsz --getpbsz --getss $dev 4096 4096 4096 # mkfs.xfs -f -N -d file,name=$tmpfile,size=1g -s size=2s illegal sector size 1024; hw sector is 4096 .... So change the sector size from '2s' to '8s' to keep away this failure. Signed-off-by: Zorro Lang Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- common/xfs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/xfs b/common/xfs index 767a4815..4bd8465b 100644 --- a/common/xfs +++ b/common/xfs @@ -542,7 +542,7 @@ _xfs_mkfs_validation_check() local tmpfile=`mktemp` local cmd="$MKFS_XFS_PROG -f -N -d file,name=$tmpfile,size=1g" - $cmd -s size=2s >/dev/null 2>&1 + $cmd -s size=8s >/dev/null 2>&1 local sum=$? $cmd -l version=2,su=260k >/dev/null 2>&1 -- 2.39.5