From 5feaa693f3eb5329ed9fad5945cbc9d7474d71fa Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Thu, 25 Jun 2020 16:46:51 -0700 Subject: [PATCH] mon/MDSMonitor: copy MDS info which may be removed Otherwise the log entry will contain garbage (and crash the mgr). Fixes: https://tracker.ceph.com/issues/46216 Signed-off-by: Patrick Donnelly (cherry picked from commit f8aaf9500e01b3dd3923b2ce89d2365bfe73dc51) --- src/mon/MDSMonitor.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc index 230793be2335c..e60c06d46a49b 100644 --- a/src/mon/MDSMonitor.cc +++ b/src/mon/MDSMonitor.cc @@ -2039,7 +2039,7 @@ bool MDSMonitor::check_health(FSMap& fsmap, bool* propose_osdmap) } for (const auto& gid : to_remove) { - auto& info = fsmap.get_info_gid(gid); + auto info = fsmap.get_info_gid(gid); const mds_info_t* rep_info = nullptr; if (info.rank >= 0) { auto fscid = fsmap.gid_fscid(gid); -- 2.39.5