From 605661f1092f81825e4db47ed250531cf1564623 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Fri, 6 Dec 2024 11:49:55 -0500 Subject: [PATCH] script: ceph-backport no longer launches firefox this script uses `pgrep firefox` to determine whether a browser is open, and will pause the ceph-backport script waiting for the commands `firefox "${backport_pr_url}` and `firefox "${redmine_url}"` to exit on Fedora release 41 with Mozilla Firefox 133.0, `pgrep firefox` always finds a process even if no browser window is open: > /usr/lib64/firefox/firefox --dbus-service /usr/bin/firefox the ceph-backport script prints these URLs as output, so it's easy enough to open them in a browser where desired Signed-off-by: Casey Bodley --- src/script/ceph-backport.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/script/ceph-backport.sh b/src/script/ceph-backport.sh index a56509e3d3abd..74f7605099cdc 100755 --- a/src/script/ceph-backport.sh +++ b/src/script/ceph-backport.sh @@ -1741,7 +1741,6 @@ fi if [ "$PR_PHASE" ] || [ "$EXISTING_PR" ] ; then maybe_update_pr_milestone_labels - pgrep firefox >/dev/null && firefox "${backport_pr_url}" fi if [ "$TRACKER_PHASE" ] ; then @@ -1792,12 +1791,10 @@ if [ "$TRACKER_PHASE" ] ; then if [ "$tracker_is_in_desired_state" ] ; then [ "$tracker_was_updated" ] && info "Backport tracker ${redmine_url} was updated" info "Backport tracker ${redmine_url} is in the desired state" - pgrep firefox >/dev/null && firefox "${redmine_url}" exit 0 fi if [ "$tracker_was_updated" ] ; then warning "backport tracker ${redmine_url} was updated, but is not in the desired state. Please check it." - pgrep firefox >/dev/null && firefox "${redmine_url}" exit 1 else data_binary="{\"issue\":{\"notes\":\"please link this Backport tracker issue with GitHub PR ${desc_should_be}\nceph-backport.sh version ${SCRIPT_VERSION}\"}}" -- 2.39.5