From 61216cdd7f06e3454ec5dd27b3ba4381f45d84d4 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 30 Oct 2009 12:38:17 -0700 Subject: [PATCH] auth: always verify auth reply, even if it's length 0 A length 0 reply is probably invalid, meaning we didn't successfully authenticate our peer! --- src/msg/SimpleMessenger.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/msg/SimpleMessenger.cc b/src/msg/SimpleMessenger.cc index 6b9e9db8c7103..607b4387c052a 100644 --- a/src/msg/SimpleMessenger.cc +++ b/src/msg/SimpleMessenger.cc @@ -1029,8 +1029,7 @@ int SimpleMessenger::Pipe::connect() if (authorizer) { bufferlist::iterator iter = authorizer_reply.begin(); - if (authorizer_reply.length() == 0 || - !authorizer->verify_reply(iter)) { + if (!authorizer->verify_reply(iter)) { dout(0) << "failed verifying authorize reply" << dendl; goto fail; } -- 2.39.5