From 621a80e6f723dbd05187e15c4a48fdfacd7221d8 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 25 Jun 2025 21:51:04 +0800 Subject: [PATCH] rgw: do not include unused header previously, when building cls_rgw, we could have following build failure: ``` In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/cls/rgw/cls_rgw_types.cc:4: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/cls/rgw/cls_rgw_types.h:15: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/rgw/rgw_basic_types.h:32: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/rgw/rgw_user_types.h:27: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/dout.h:29: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/ceph_context.h:41: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config_proxy.h:7: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config.h:28: In file included from /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/config_values.h:59: /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found 1 | #include "global_legacy_options.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~ ``` but it turned out that `cls_rgw_types.h` does not use `dout.h` at all. so, in this change, we just drop this include. this helps to reduce the build dependency. Signed-off-by: Kefu Chai --- src/rgw/rgw_user_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rgw/rgw_user_types.h b/src/rgw/rgw_user_types.h index 2329eca3d60..b731269e9cf 100644 --- a/src/rgw/rgw_user_types.h +++ b/src/rgw/rgw_user_types.h @@ -24,7 +24,6 @@ #include #include -#include "common/dout.h" #include "common/Formatter.h" // strong typedef to std::string -- 2.39.5