From 6265452c50c2bbd0283a66d03d6a8538c2285293 Mon Sep 17 00:00:00 2001 From: Zhang Song Date: Sun, 9 Jul 2023 12:22:58 +0800 Subject: [PATCH] crimson/os/seastore: add metrics about total invalidated transactions Signed-off-by: Zhang Song --- src/crimson/os/seastore/cache.cc | 11 +++++++++-- src/crimson/os/seastore/cache.h | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/crimson/os/seastore/cache.cc b/src/crimson/os/seastore/cache.cc index 0b0f5cd332e5c..52c08712d2896 100644 --- a/src/crimson/os/seastore/cache.cc +++ b/src/crimson/os/seastore/cache.cc @@ -225,9 +225,9 @@ void Cache::register_metrics() "cache", { sm::make_counter( - "trans_invalidated", + "trans_invalidated_by_extent", counter, - sm::description("total number of transaction invalidated"), + sm::description("total number of transactions invalidated by extents"), {src_label, ext_label} ), } @@ -295,6 +295,12 @@ void Cache::register_metrics() metrics.add_group( "cache", { + sm::make_counter( + "trans_invalidated", + efforts.total_trans_invalidated, + sm::description("total number of transactions invalidated"), + {src_label} + ), sm::make_counter( "invalidated_delta_bytes", efforts.mutate_delta_bytes, @@ -843,6 +849,7 @@ void Cache::mark_transaction_conflicted( auto& efforts = get_by_src(stats.invalidated_efforts_by_src, t.get_src()); + ++efforts.total_trans_invalidated; auto& counter = get_by_ext(efforts.num_trans_invalidated, conflicting_extent.get_type()); diff --git a/src/crimson/os/seastore/cache.h b/src/crimson/os/seastore/cache.h index 2f7346fe3583b..3185c49012fc3 100644 --- a/src/crimson/os/seastore/cache.h +++ b/src/crimson/os/seastore/cache.h @@ -1438,6 +1438,7 @@ private: io_stat_t fresh; io_stat_t fresh_ool_written; counter_by_extent_t num_trans_invalidated; + uint64_t total_trans_invalidated = 0; uint64_t num_ool_records = 0; uint64_t ool_record_bytes = 0; }; -- 2.39.5