From 62aa9d9d2ab92bf2e096a182e8902dd06d08632e Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 24 Sep 2019 15:04:56 +0800 Subject: [PATCH] mon/MonCommands: improve "osd pool create" command validation both `expected_num_objects` and `size` are required to be greater or equal to 0, and monitor will return -EINVAL at seeing a negative value of either of them. so let's fail earlier. Signed-off-by: Kefu Chai --- src/mon/MonCommands.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mon/MonCommands.h b/src/mon/MonCommands.h index 273b019914d..e188f197d2c 100644 --- a/src/mon/MonCommands.h +++ b/src/mon/MonCommands.h @@ -1022,8 +1022,8 @@ COMMAND("osd pool create " \ "name=pool_type,type=CephChoices,strings=replicated|erasure,req=false " \ "name=erasure_code_profile,type=CephString,req=false,goodchars=[A-Za-z0-9-_.] " \ "name=rule,type=CephString,req=false " \ - "name=expected_num_objects,type=CephInt,req=false " \ - "name=size,type=CephInt,req=false " \ + "name=expected_num_objects,type=CephInt,range=0,req=false " \ + "name=size,type=CephInt,range=0,req=false " \ "name=pg_num_min,type=CephInt,range=0,req=false " \ "name=target_size_bytes,type=CephInt,range=0,req=false " \ "name=target_size_ratio,type=CephFloat,range=0|1,req=false",\ -- 2.39.5