From 67dc9ba0417676c8406cbd2d338eeda5c2430b34 Mon Sep 17 00:00:00 2001 From: Ivo Almeida Date: Thu, 30 May 2024 11:25:33 +0100 Subject: [PATCH] lint fixes --- .../workbench-layout/workbench-layout.component.scss | 2 +- .../navigation/navigation/navigation.component.html | 6 ++++-- .../navigation/navigation/navigation.component.scss | 2 +- .../src/app/shared/components/components.module.ts | 4 ++-- .../telemetry-notification.component.scss | 4 ++-- .../frontend/src/styles/carbon-overrides.scss | 10 +++++----- .../src/styles/defaults/_bootstrap-defaults.scss | 2 +- .../frontend/src/styles/themes/_upstream.scss | 4 ++-- 8 files changed, 18 insertions(+), 16 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/layouts/workbench-layout/workbench-layout.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/layouts/workbench-layout/workbench-layout.component.scss index 6ac942a2f018c..547ce4aecc0eb 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/layouts/workbench-layout/workbench-layout.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/layouts/workbench-layout/workbench-layout.component.scss @@ -7,9 +7,9 @@ } .container-fluid { - top: 48px; overflow: auto; position: absolute; + top: 48px; } .rgw-dashboard { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html index 3730420d3756a..c44a42c5126c4 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html @@ -2,7 +2,9 @@ - + @@ -171,7 +173,7 @@ size="20"> Overview + class="tc_submenuitem tc_submenuitem_rgw_overview">Overview Buckets diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.scss index f716d696651c8..e3b4e80e5e30e 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.scss @@ -194,9 +194,9 @@ $sidebar-width: 20.8rem; left: 0; overflow-y: auto; position: relative; - z-index: 999; transition: all 0.3s; width: $sidebar-width; + z-index: 999; &.active { // margin-left: -$sidebar-width; diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts index 6e2d072976cd6..21d333cc0f90a 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts @@ -80,7 +80,7 @@ import { UpgradableComponent } from './upgradable/upgradable.component'; NgbTimepickerModule, UIShellModule, ButtonModule, - NotificationModule, + NotificationModule ], declarations: [ SparklineComponent, @@ -162,4 +162,4 @@ import { UpgradableComponent } from './upgradable/upgradable.component'; UpgradableComponent ] }) -export class ComponentsModule {} \ No newline at end of file +export class ComponentsModule {} diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.scss b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.scss index 4faa60684a1a3..53efbe18980ff 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.scss +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.scss @@ -23,9 +23,9 @@ a { } .telemetry-notification { - z-index: 99999; - position: absolute; bottom: 25px; + position: absolute; right: 50%; transform: translateX(50%); + z-index: 99999; } diff --git a/src/pybind/mgr/dashboard/frontend/src/styles/carbon-overrides.scss b/src/pybind/mgr/dashboard/frontend/src/styles/carbon-overrides.scss index 7a276343831e0..ffdc83655ce48 100644 --- a/src/pybind/mgr/dashboard/frontend/src/styles/carbon-overrides.scss +++ b/src/pybind/mgr/dashboard/frontend/src/styles/carbon-overrides.scss @@ -1,16 +1,16 @@ -@use "@carbon/styles/scss/config" with ( - $font-path: "~@ibm/plex", +@use '@carbon/styles/scss/config' with ( + $font-path: '~@ibm/plex', $flex-grid-columns: 16, $use-flexbox-grid: true, ); -@use "./themes/upstream"; +@use './themes/upstream'; @use '@carbon/styles/scss/compat/themes' as compat; @use '@carbon/styles/scss/themes'; @use '@carbon/styles/scss/theme' with ( $theme: compat.$g90, $fallback: upstream.$theme, ); -@use "@carbon/styles"; +@use '@carbon/styles'; @use '@carbon/type'; /********************************************************************************** @@ -55,7 +55,7 @@ a.cds--side-nav__link > .cds--side-nav__link-text { a.cds--header__menu-item, .cds--header__action, -.cds--header{ +.cds--header { block-size: 3.9rem; font-size: calc(type.type-scale(4) + 0.5px); } diff --git a/src/pybind/mgr/dashboard/frontend/src/styles/defaults/_bootstrap-defaults.scss b/src/pybind/mgr/dashboard/frontend/src/styles/defaults/_bootstrap-defaults.scss index 76fce50bd1ba4..16cbcac3e321d 100644 --- a/src/pybind/mgr/dashboard/frontend/src/styles/defaults/_bootstrap-defaults.scss +++ b/src/pybind/mgr/dashboard/frontend/src/styles/defaults/_bootstrap-defaults.scss @@ -110,7 +110,7 @@ $code-block-bg: #f7f7f9 !default; // Typography -// WARNING: This was clashing with Carbon's font-family +// WARNING: This was clashing with Carbon's font-family // $font-family-sans-serif: 'Helvetica Neue', Helvetica, Arial, 'Noto Sans', sans-serif, // 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji' !default; diff --git a/src/pybind/mgr/dashboard/frontend/src/styles/themes/_upstream.scss b/src/pybind/mgr/dashboard/frontend/src/styles/themes/_upstream.scss index 189663b0de8f8..970d5303314b0 100644 --- a/src/pybind/mgr/dashboard/frontend/src/styles/themes/_upstream.scss +++ b/src/pybind/mgr/dashboard/frontend/src/styles/themes/_upstream.scss @@ -5,5 +5,5 @@ $theme: ( text-secondary: #c6c6c6, btn-primary: vv.$primary, border-interactive: vv.$primary, - background: vv.$secondary, -); \ No newline at end of file + background: vv.$secondary +); -- 2.39.5