From 68c5be0a5a58470b21ae52c91a639195872fb7a3 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 3 Oct 2020 19:05:15 +0800 Subject: [PATCH] crimson/osd: mark Operation::dump_detail() private Operation::dump_detail() is called by Operation::dump(), the latter is a member of Blocker. so there is no need to mark dump_detail() protected or public to grant the access Operation::dump() the access to this method. Signed-off-by: Kefu Chai --- src/crimson/osd/osd_operation.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/crimson/osd/osd_operation.h b/src/crimson/osd/osd_operation.h index 2a2250e6571a5..0641a7bfc43fd 100644 --- a/src/crimson/osd/osd_operation.h +++ b/src/crimson/osd/osd_operation.h @@ -204,7 +204,7 @@ class Operation : public boost::intrusive_ref_counter< void dump_brief(ceph::Formatter *f); virtual ~Operation() = default; - protected: + private: virtual void dump_detail(ceph::Formatter *f) const = 0; private: @@ -235,10 +235,6 @@ std::ostream &operator<<(std::ostream &, const Operation &op); template class OperationT : public Operation { - -protected: - virtual void dump_detail(ceph::Formatter *f) const = 0; - public: static constexpr const char *type_name = OP_NAMES[static_cast(T::type)]; using IRef = boost::intrusive_ptr; @@ -252,6 +248,9 @@ public: } virtual ~OperationT() = default; + +private: + virtual void dump_detail(ceph::Formatter *f) const = 0; }; /** -- 2.39.5