From 698670726ad0a8c64b84c893b0a46cbf8b3442df Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Thu, 7 Feb 2013 20:04:39 +0100 Subject: [PATCH] common/WorkQueue.h: use empty() instead of size() Fix warning for usage of out->size() in _void_dequeue(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). warning from cppchecker was: [common/WorkQueue.h:97]: (performance) Possible inefficient checking for 'queue' emptiness. Signed-off-by: Danny Al-Gaaf --- src/common/WorkQueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h index b19a6a20cb359..ced952c49cd5a 100644 --- a/src/common/WorkQueue.h +++ b/src/common/WorkQueue.h @@ -94,7 +94,7 @@ public: void *_void_dequeue() { list *out(new list); _dequeue(out); - if (out->size()) { + if (!out->empty()) { return (void *)out; } else { delete out; -- 2.39.5