From 69e465b2cf181a28da7d771bfc6997c97ea4d772 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Rados=C5=82aw=20Zarzy=C5=84ski?= <rzarzyns@redhat.com>
Date: Tue, 19 Apr 2022 17:32:40 +0200
Subject: [PATCH] crimson/osd: migrate InternalClientRequest to new tracking
 infra.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
---
 .../osd_operations/internal_client_request.cc | 35 +++++++++++++------
 .../osd_operations/internal_client_request.h  | 13 +++++++
 2 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/src/crimson/osd/osd_operations/internal_client_request.cc b/src/crimson/osd/osd_operations/internal_client_request.cc
index b4b61ea66f6..cf887f351aa 100644
--- a/src/crimson/osd/osd_operations/internal_client_request.cc
+++ b/src/crimson/osd/osd_operations/internal_client_request.cc
@@ -11,6 +11,16 @@ namespace {
   }
 }
 
+namespace crimson {
+  template <>
+  struct EventBackendRegistry<osd::InternalClientRequest> {
+    static std::tuple<> get_backends() {
+      return {};
+    }
+  };
+}
+
+
 namespace crimson::osd {
 
 InternalClientRequest::InternalClientRequest(Ref<PG> pg)
@@ -39,23 +49,26 @@ CommonPGPipeline& InternalClientRequest::pp()
 
 seastar::future<> InternalClientRequest::start()
 {
+  track_event<StartEvent>();
   return crimson::common::handle_system_shutdown([this] {
     return seastar::repeat([this] {
       logger().debug("{}: in repeat", *this);
       return interruptor::with_interruption([this]() mutable {
-        return with_blocking_future_interruptible<interruptor::condition>(
-          handle.enter(pp().wait_for_active)
+        return enter_stage<interruptor>(
+	  pp().wait_for_active
         ).then_interruptible([this] {
-          return with_blocking_future_interruptible<interruptor::condition>(
-            pg->wait_for_active_blocker.wait());
+          return with_blocking_event<PGActivationBlocker::BlockingEvent,
+	  			     interruptor>([this] (auto&& trigger) {
+            return pg->wait_for_active_blocker.wait(std::move(trigger));
+          });
         }).then_interruptible([this] {
-          return with_blocking_future_interruptible<interruptor::condition>(
-            handle.enter(pp().recover_missing)
+          return enter_stage<interruptor>(
+            pp().recover_missing
           ).then_interruptible([this] {
             return do_recover_missing(pg, get_target_oid());
           }).then_interruptible([this] {
-            return with_blocking_future_interruptible<interruptor::condition>(
-              handle.enter(pp().get_obc)
+            return enter_stage<interruptor>(
+              pp().get_obc
             ).then_interruptible([this] () -> PG::load_obc_iertr::future<> {
               logger().debug("{}: getting obc lock", *this);
               return seastar::do_with(create_osd_ops(),
@@ -67,9 +80,7 @@ seastar::future<> InternalClientRequest::start()
                 assert(ret == 0);
                 return pg->with_locked_obc(get_target_oid(), op_info,
                   [&osd_ops, this](auto obc) {
-                  return with_blocking_future_interruptible<interruptor::condition>(
-                    handle.enter(pp().process)
-                  ).then_interruptible(
+                  return enter_stage<interruptor>(pp().process).then_interruptible(
                     [obc=std::move(obc), &osd_ops, this] {
                     return pg->do_osd_ops(
                       std::move(obc),
@@ -109,6 +120,8 @@ seastar::future<> InternalClientRequest::start()
           return seastar::stop_iteration::no;
         }
       }, pg);
+    }).then([this] {
+      track_event<CompletionEvent>();
     });
   });
 }
diff --git a/src/crimson/osd/osd_operations/internal_client_request.h b/src/crimson/osd/osd_operations/internal_client_request.h
index a1b538c729e..6ad77121df0 100644
--- a/src/crimson/osd/osd_operations/internal_client_request.h
+++ b/src/crimson/osd/osd_operations/internal_client_request.h
@@ -6,7 +6,9 @@
 #include "crimson/common/type_helpers.h"
 #include "crimson/osd/osd_operation.h"
 #include "crimson/osd/osd_operations/client_request_common.h"
+#include "crimson/osd/osd_operations/common/pg_pipeline.h"
 #include "crimson/osd/pg.h"
+#include "crimson/osd/pg_activation_blocker.h"
 
 namespace crimson::osd {
 
@@ -43,6 +45,17 @@ private:
 
   Ref<PG> pg;
   OpInfo op_info;
+
+public:
+  std::tuple<
+    StartEvent,
+    CommonPGPipeline::WaitForActive::BlockingEvent,
+    PGActivationBlocker::BlockingEvent,
+    CommonPGPipeline::RecoverMissing::BlockingEvent,
+    CommonPGPipeline::GetOBC::BlockingEvent,
+    CommonPGPipeline::Process::BlockingEvent,
+    CompletionEvent
+  > tracking_events;
 };
 
 } // namespace crimson::osd
-- 
2.39.5