From 6a1189d1eb74d9c3d7653f4f32c480158d260901 Mon Sep 17 00:00:00 2001 From: Alfredo Deza Date: Fri, 8 Sep 2017 11:47:09 -0400 Subject: [PATCH] ceph-volume tests prove all volume tags have to match in vgs Signed-off-by: Alfredo Deza (cherry picked from commit fe2a7106decb586e83f5b60d6c18c454afe4883e) --- src/ceph-volume/ceph_volume/tests/devices/lvm/test_api.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_api.py b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_api.py index abb1662c7b75f..845a6368f2e71 100644 --- a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_api.py +++ b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_api.py @@ -267,6 +267,13 @@ class TestVolumeGroups(object): assert len(volume_groups) == 1 assert volume_groups[0].vg_name == 'volume1' + def test_filter_by_tag_does_not_match_one(self, volume_groups): + vg_tags = "ceph.group=dmcache,ceph.disk_type=ssd" + osd = api.VolumeGroup(vg_name='volume1', vg_path='/dev/vg/lv', vg_tags=vg_tags) + volume_groups.append(osd) + volume_groups.filter(vg_tags={'ceph.group': 'data', 'ceph.disk_type': 'ssd'}) + assert volume_groups == [] + def test_filter_by_vg_name(self, volume_groups): vg_tags = "ceph.type=data,ceph.fsid=000-aaa" osd = api.VolumeGroup(vg_name='ceph_vg', vg_tags=vg_tags) -- 2.39.5