From 6b027557e6974bde86f05704c0ad12bfcf66fd3a Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Fri, 6 Oct 2017 14:35:42 +0200 Subject: [PATCH] osd: fix `set_fact build dedicated_devices` Use an intermediate variable to build the final `dedicated_devices` list to avoid duplicate entry in that array. (We need a 1:1 relation between `dedicated_devices` and `devices` since we are using a `with_together` later. Signed-off-by: Guillaume Abrioux --- roles/ceph-osd/tasks/check_devices.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/ceph-osd/tasks/check_devices.yml b/roles/ceph-osd/tasks/check_devices.yml index 339b8b915..d4aaaa338 100644 --- a/roles/ceph-osd/tasks/check_devices.yml +++ b/roles/ceph-osd/tasks/check_devices.yml @@ -20,14 +20,14 @@ - name: set_fact build dedicated_devices from resolved symlinks set_fact: - dedicated_devices: "{{ dedicated_devices | default([]) + [ item.stdout ] }}" + dedicated_devices_tmp: "{{ dedicated_devices_tmp | default([]) + [ item.stdout ] }}" with_items: "{{ dedicated_devices_prepare_canonicalize.results }}" when: - osd_scenario == 'non-collocated' - name: set_fact build final dedicated_devices list set_fact: - dedicated_devices: "{{ dedicated_devices | reject('search','/dev/disk') | list }}" + dedicated_devices: "{{ dedicated_devices_tmp | reject('search','/dev/disk') | list }}" when: - osd_scenario == 'non-collocated' -- 2.39.5