From 6b3b3d3ef1fc6c354c30d5cfd683f5341ece53bf Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Mon, 6 Nov 2023 11:19:44 -0500 Subject: [PATCH] common: admin socket catches exception by reference MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit probably not a real bug, but resolves a compiler warning: src/common/admin_socket.cc: In member function ‘int RaiseHook::parse_signal(std::string&&, ceph::Formatter*, std::ostream&)’: src/common/admin_socket.cc:869:21: warning: catching polymorphic type ‘class std::invalid_argument’ by value [-Wcatch-value=] 869 | } catch (std::invalid_argument) { | ^~~~~~~~~~~~~~~~ Fixes: https://tracker.ceph.com/issues/63455 Signed-off-by: Casey Bodley --- src/common/admin_socket.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/admin_socket.cc b/src/common/admin_socket.cc index 2ed3179e807..c4a37b29ed9 100644 --- a/src/common/admin_socket.cc +++ b/src/common/admin_socket.cc @@ -866,7 +866,7 @@ class RaiseHook: public AdminSocketHook { errss << "signal number should be an integer in the range [1..64]" << std::endl; return -EINVAL; } - } catch (std::invalid_argument) { + } catch (const std::invalid_argument&) { auto sig_it = known_signals.find(sigdesc); if (sig_it == known_signals.end()) { errss << "unknown signal name; use -l to see recognized names" << std::endl; -- 2.39.5