From 6bd65c707208afdc3d81d3146ac171d7621c26ee Mon Sep 17 00:00:00 2001 From: Anthony Iliopoulos Date: Fri, 21 Jan 2022 14:58:01 +0100 Subject: [PATCH] common/rc: fix group detection regex to strictly match required name _require_group greps for the required group string in /etc/group but this can partially match other groups or group member names and falsely return success where it should fail. Make the regex more specific so that it can unambigiously match only the exact group name rather than any other group that happens to match as a substring or any matching username from the group member list field. Signed-off-by: Anthony Iliopoulos Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index b3289de9..73f484bd 100644 --- a/common/rc +++ b/common/rc @@ -2428,7 +2428,7 @@ _require_group() if [ -n "$1" ];then qa_group=$1 fi - _cat_group | grep -q $qa_group + _cat_group | grep -q "^$qa_group:" [ "$?" == "0" ] || _notrun "$qa_group group not defined." } -- 2.39.5