From 6ca60061bb034adf5a32f790eb04f4f4e69ae286 Mon Sep 17 00:00:00 2001 From: Loic Dachary Date: Mon, 25 May 2015 15:44:53 +0200 Subject: [PATCH] erasure-code: lrc size test depends on layer semantic When the lrc layers are defined, the semantic of the D,c and _ characters are defined, the rest is undefined. The test that verifies the guard against layers of different size uses the A character which is undefined. Depending on the implementation, the size test could fail because the A character is undefined and a guard to forbid undefined characters is added. Replace A with D to make sure the undefined character A will not interfere with the test. This may seem nitpicking but it actually caused problems after a code refactor that will appear in a few commits from here. Signed-off-by: Loic Dachary --- src/test/erasure-code/TestErasureCodeLrc.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/erasure-code/TestErasureCodeLrc.cc b/src/test/erasure-code/TestErasureCodeLrc.cc index c24b32364f5a..c03195950e82 100644 --- a/src/test/erasure-code/TestErasureCodeLrc.cc +++ b/src/test/erasure-code/TestErasureCodeLrc.cc @@ -384,12 +384,12 @@ TEST(ErasureCodeLrc, layers_sanity_checks) ErasureCodeProfile profile; profile["directory"] = ".libs"; profile["mapping"] = - "AA"; + "DD"; const char *description_string = "[ " - " [ \"AA??\", \"\" ], " - " [ \"AA\", \"\" ], " - " [ \"AA\", \"\" ], " + " [ \"DD??\", \"\" ], " + " [ \"DD\", \"\" ], " + " [ \"DD\", \"\" ], " "]"; profile["layers"] = description_string; EXPECT_EQ(ERROR_LRC_MAPPING_SIZE, lrc.init(profile, &cerr)); -- 2.47.3