From 6d3e13f0e139e215d378e0a040e8b856938fe9d3 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 15 Jul 2013 09:58:08 -0700 Subject: [PATCH] rgw: fix more warnings test/test_rgw_admin_opstate.cc: In member function 'int admin_log::test_helper::extract_input(int, char**)': warning: test/test_rgw_admin_opstate.cc:129:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:131:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:133:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_opstate.cc:135:24: comparison between signed and unsigned integer expressions [-Wsign-compare] test/test_rgw_admin_log.cc: In member function 'int admin_log::test_helper::extract_input(int, char**)': warning: test/test_rgw_admin_log.cc:132:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:134:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:136:24: comparison between signed and unsigned integer expressions [-Wsign-compare] warning: test/test_rgw_admin_log.cc:138:24: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Sage Weil --- src/test/test_rgw_admin_log.cc | 2 +- src/test/test_rgw_admin_opstate.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_rgw_admin_log.cc b/src/test/test_rgw_admin_log.cc index 876c76973e052..67ba0b12d968c 100644 --- a/src/test/test_rgw_admin_log.cc +++ b/src/test/test_rgw_admin_log.cc @@ -124,7 +124,7 @@ class test_helper { int test_helper::extract_input(int argc, char *argv[]){ #define ERR_CHECK_NEXT_PARAM(o) \ - if((loop + 1) >= argc)return -1; \ + if(((int)loop + 1) >= argc)return -1; \ else o = argv[loop+1]; for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){ diff --git a/src/test/test_rgw_admin_opstate.cc b/src/test/test_rgw_admin_opstate.cc index cfd709043dd60..8f95db4cee0dd 100644 --- a/src/test/test_rgw_admin_opstate.cc +++ b/src/test/test_rgw_admin_opstate.cc @@ -121,7 +121,7 @@ class test_helper { int test_helper::extract_input(int argc, char *argv[]){ #define ERR_CHECK_NEXT_PARAM(o) \ - if((loop + 1) >= argc)return -1; \ + if(((int)loop + 1) >= argc)return -1; \ else o = argv[loop+1]; for(unsigned loop = 1;loop < (unsigned)argc; loop += 2){ -- 2.39.5