From 6d5751a5245577db3cc3591a51e64bfd13716574 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Wed, 26 Jun 2024 18:17:13 -0400 Subject: [PATCH] cmake: work around xxhash 'inlining failed' errors in debug builds MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit rgw enables the XXH_INLINE_ALL define, but this causes debug builds to fail with errors like "inlining failed in call to ‘always_inline’" for build types Debug and RelWithDebInfo, add extra define XXH_NO_INLINE_HINTS to remove the always_inline hints causing this error Signed-off-by: Casey Bodley --- src/rgw/CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/rgw/CMakeLists.txt b/src/rgw/CMakeLists.txt index bcbde72d8aaba..25151fb24fb0a 100644 --- a/src/rgw/CMakeLists.txt +++ b/src/rgw/CMakeLists.txt @@ -312,6 +312,11 @@ target_include_directories(rgw_common PUBLIC "${CMAKE_SOURCE_DIR}/src/rgw" PUBLIC "${LUA_INCLUDE_DIR}") +# work around https://github.com/Cyan4973/xxHash/issues/943 for debug builds +target_compile_definitions(rgw_common PUBLIC + $<$:XXH_NO_INLINE_HINTS=1> + $<$:XXH_NO_INLINE_HINTS=1>) + if(WITH_RADOSGW_KAFKA_ENDPOINT) # used by rgw_kafka.cc target_link_libraries(rgw_common -- 2.39.5