From 6e9d6f00243c5a18553c870e6798a3bf61e3722f Mon Sep 17 00:00:00 2001 From: sageweil Date: Wed, 28 Nov 2007 01:22:24 +0000 Subject: [PATCH] valgrind on newsyn git-svn-id: https://ceph.svn.sf.net/svnroot/ceph@2125 29311d96-e01e-0410-9327-a35deaab8ce9 --- trunk/ceph/messages/MClientReply.h | 1 + trunk/ceph/messages/MOSDPGQuery.h | 5 +- trunk/ceph/msg/Message.h | 1 + trunk/ceph/valgrind.supp | 126 +++++++++++++++++++++++++++++ 4 files changed, 130 insertions(+), 3 deletions(-) diff --git a/trunk/ceph/messages/MClientReply.h b/trunk/ceph/messages/MClientReply.h index 8de58ba1bef0f..71290843bb8f8 100644 --- a/trunk/ceph/messages/MClientReply.h +++ b/trunk/ceph/messages/MClientReply.h @@ -141,6 +141,7 @@ struct InodeStat { * note: encoding matches struct ceph_client_reply_inode */ struct ceph_client_reply_inode e; + memset(&e, 0, sizeof(e)); e.ino = in->inode.ino; e.layout = in->inode.layout; e.ctime = in->inode.ctime.tv_ref(); diff --git a/trunk/ceph/messages/MOSDPGQuery.h b/trunk/ceph/messages/MOSDPGQuery.h index 70dbfdbb96fd7..dc8ee664e5fd4 100644 --- a/trunk/ceph/messages/MOSDPGQuery.h +++ b/trunk/ceph/messages/MOSDPGQuery.h @@ -38,13 +38,12 @@ class MOSDPGQuery : public Message { char *get_type_name() { return "PGq"; } void encode_payload() { - payload.append((char*)&epoch, sizeof(epoch)); + ::_encode(epoch, payload); ::_encode(pg_list, payload); } void decode_payload() { int off = 0; - payload.copy(off, sizeof(epoch), (char*)&epoch); - off += sizeof(epoch); + ::_decode(epoch, payload, off); ::_decode(pg_list, payload, off); } }; diff --git a/trunk/ceph/msg/Message.h b/trunk/ceph/msg/Message.h index 6bf468524b2ad..75b50c4be411a 100644 --- a/trunk/ceph/msg/Message.h +++ b/trunk/ceph/msg/Message.h @@ -120,6 +120,7 @@ public: Message() { }; Message(int t) { env.type = t; + env.data_off = 0; } virtual ~Message() { } diff --git a/trunk/ceph/valgrind.supp b/trunk/ceph/valgrind.supp index 356df039050c4..c46970e023a99 100644 --- a/trunk/ceph/valgrind.supp +++ b/trunk/ceph/valgrind.supp @@ -40,6 +40,22 @@ fun:_ZN4Rank10start_rankEv fun:main } +{ + + Memcheck:Param + socketcall.sendto(msg) + fun:send + fun:get_mapping + fun:__nscd_get_map_ref + fun:nscd_gethst_r + fun:__nscd_gethostbyname_r + fun:gethostbyname_r@@GLIBC_2.2.5 + fun:gethostbyname + fun:_ZN4Rank8Accepter5startEv + fun:_ZN4Rank10start_rankEv + fun:_Z17mpi_bootstrap_newRiRPPcP6MonMap + fun:main +} # gethostbyname @@ -60,3 +76,113 @@ obj:/lib/libc-2.6.1.so } +# mpi on issdm +{ + + Memcheck:Overlap + fun:memcpy + fun:MPIR_Localcopy + fun:MPIR_Gather + fun:MPI_Gather + fun:_Z17mpi_bootstrap_newRiRPPcP6MonMap + fun:main +} +{ + + Memcheck:Param + writev(vector[...]) + fun:writev + fun:MPIDU_Sock_writev + fun:MPIDI_CH3_iStartMsgv + fun:MPIDI_CH3_EagerContigSend + fun:MPID_Send + fun:MPIC_Send + fun:MPIR_Bcast + fun:MPI_Bcast + fun:_Z17mpi_bootstrap_newRiRPPcP6MonMap + fun:main +} +{ + + Memcheck:Param + write(buf) + obj:/lib64/tls/libpthread-2.3.4.so + fun:MPIDU_Sock_write + fun:MPIDI_CH3_iSend + fun:MPID_Isend + fun:MPIC_Sendrecv + fun:MPIR_Barrier + fun:MPI_Barrier + fun:_Z17mpi_bootstrap_newRiRPPcP6MonMap + fun:main +} +{ + + Memcheck:Param + write(buf) + obj:/lib64/tls/libpthread-2.3.4.so + fun:MPIDU_Sock_write + fun:MPIDI_CH3_iStartMsg + fun:MPIDI_CH3U_VC_SendClose + fun:MPIDI_PG_Close_VCs + fun:MPID_Finalize + fun:MPI5: + fun:main +} +{ + + Memcheck:Param + write(buf) + obj:/lib64/tls/libpthread-2.3.4.so + fun:MPIDU_Sock_write + fun:MPIDI_CH3_iSend + fun:MPID_Isend + fun:MPIC_Sendrecv + fun:MPIR_Barrier + fun:MPI_Barrier + fun:main +} +{ + + Memcheck:Param + write(buf) + obj:/lib64/tls/libpthread-2.3.4.so + fun:MPIDU_Sock_write + fun:MPIDI_CH3_iStartMsg + fun:MPIDI_CH3U_VC_SendClose + fun:MPIDI_PG_Close_VCs + fun:MPID_Finalize + fun:MPI_Finalize + fun:main +} + { + + Memcheck:Param + writev(vector[...]) + fun:writev + fun:MPIDU_Socki_handle_write + fun:MPIDU_Sock_wait + fun:MPIDI_CH3_Progress_wait + fun:MPIC_Wait + fun:MPIC_Send + fun:MPIR_Gather + fun:MPI_Gather + fun:_Z17mpi_bootstrap_newRiRPPcP6MonMap + fun:main +} + -- 2.39.5