From 7012835d2b1880e7a6ef9a224df456b2dd1024cc Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Han?= Date: Thu, 23 Aug 2018 11:21:54 +0200 Subject: [PATCH] ci: stop using different images on the same run MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is no point of using hosts running on atomic AND centos hosts. So let's run containerized scenarios on Atomic only. This solves this error here: ``` fatal: [client2]: FAILED! => { "failed": true } MSG: The conditional check 'ceph_current_status.rc == 0' failed. The error was: error while evaluating conditional (ceph_current_status.rc == 0): 'dict object' has no attribute 'rc' The error appears to have been in '/home/jenkins-build/build/workspace/ceph-ansible-nightly-luminous-stable-3.1-ooo_collocation/roles/ceph-defaults/tasks/facts.yml': line 74, column 3, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: - name: set_fact ceph_current_status (convert to json) ^ here ``` From https://2.jenkins.ceph.com/view/ceph-ansible-stable3.1/job/ceph-ansible-nightly-luminous-stable-3.1-ooo_collocation/37/consoleFull#1765217701b5dd38fa-a56e-4233-a5ca-584604e56e3a What's happening here is all the hosts excepts the clients are running atomic, so here: https://github.com/ceph/ceph-ansible/blob/master/site-docker.yml.sample#L62 The condition will skipped all the nodes excepts the clients, thus when running ceph-default, the task "is ceph running already?" is skipped but the task above needs the rc of the skipped task. This is not an error from the playbook, it's a CI setup issue. Signed-off-by: Sébastien Han --- .../centos/7/docker-collocation/vagrant_variables.yml | 2 +- tests/functional/centos/7/ooo-collocation/vagrant_variables.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional/centos/7/docker-collocation/vagrant_variables.yml b/tests/functional/centos/7/docker-collocation/vagrant_variables.yml index e5cabf82c..05862eb9f 100644 --- a/tests/functional/centos/7/docker-collocation/vagrant_variables.yml +++ b/tests/functional/centos/7/docker-collocation/vagrant_variables.yml @@ -46,7 +46,7 @@ disks: "[ '/dev/sda', '/dev/sdb' ]" # - https://atlas.hashicorp.com/boxes/search?utf8=✓&sort=&provider=virtualbox&q= # - https://download.gluster.org/pub/gluster/purpleidea/vagrant/ vagrant_box: centos/atomic-host -client_vagrant_box: centos/7 +# client_vagrant_box: centos/7 #ssh_private_key_path: "~/.ssh/id_rsa" # The sync directory changes based on vagrant box # Set to /home/vagrant/sync for Centos/7, /home/{ user }/vagrant for openstack and defaults to /vagrant diff --git a/tests/functional/centos/7/ooo-collocation/vagrant_variables.yml b/tests/functional/centos/7/ooo-collocation/vagrant_variables.yml index d7e2d21a5..ecde35010 100644 --- a/tests/functional/centos/7/ooo-collocation/vagrant_variables.yml +++ b/tests/functional/centos/7/ooo-collocation/vagrant_variables.yml @@ -46,7 +46,7 @@ disks: "[ '/dev/sda', '/dev/sdb', '/dev/sdc' ]" # - https://atlas.hashicorp.com/boxes/search?utf8=✓&sort=&provider=virtualbox&q= # - https://download.gluster.org/pub/gluster/purpleidea/vagrant/ vagrant_box: centos/atomic-host -client_vagrant_box: centos/7 +# client_vagrant_box: centos/7 #ssh_private_key_path: "~/.ssh/id_rsa" # The sync directory changes based on vagrant box # Set to /home/vagrant/sync for Centos/7, /home/{ user }/vagrant for openstack and defaults to /vagrant -- 2.39.5