From 7044a9d6ffc6485ec7fffc4f947b0683f1f0ffc9 Mon Sep 17 00:00:00 2001 From: Jason Dillaman Date: Tue, 22 Dec 2020 13:56:59 -0500 Subject: [PATCH] librbd/migration: fixed missing return statements on stream error path Signed-off-by: Jason Dillaman --- src/librbd/migration/HttpStream.cc | 1 + src/librbd/migration/S3Stream.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/src/librbd/migration/HttpStream.cc b/src/librbd/migration/HttpStream.cc index 7b8f91a325c..fa3cc00320e 100644 --- a/src/librbd/migration/HttpStream.cc +++ b/src/librbd/migration/HttpStream.cc @@ -56,6 +56,7 @@ void HttpStream::close(Context* on_finish) { if (!m_http_client) { on_finish->complete(0); + return; } m_http_client->close(on_finish); diff --git a/src/librbd/migration/S3Stream.cc b/src/librbd/migration/S3Stream.cc index 222a08ee3fe..46165f208f9 100644 --- a/src/librbd/migration/S3Stream.cc +++ b/src/librbd/migration/S3Stream.cc @@ -128,6 +128,7 @@ void S3Stream::close(Context* on_finish) { if (!m_http_client) { on_finish->complete(0); + return; } m_http_client->close(on_finish); -- 2.39.5