From 70eb1d64ac1ea6e7202d42571f83c34d3758ad8f Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Wed, 5 Mar 2025 13:22:38 -0500 Subject: [PATCH] cmake/cephfs: fix options to enable client and dependencies invoking cmake with -DWITH_LIBCEPHFS=OFF fails to configure the client target: CMake Error at src/client/CMakeLists.txt:13 (target_link_libraries): Target "client" links to: Boost::locale but the target was not found. Possible reasons include: * There is a typo in the target name. * A find_package call is missing for an IMPORTED target. * An ALIAS target is missing. because the client target is not conditional on WITH_LIBCEPHFS in src/CMakeLists.txt: add_subdirectory(client) if(WITH_LIBCEPHFS) because client is also needed for ceph-fuse, make the client and its dependencies depend on WITH_LIBCEPHFS OR WITH_FUSE Signed-off-by: Casey Bodley --- CMakeLists.txt | 2 +- src/CMakeLists.txt | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a2a911af940c7..fea65517dcf86 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -729,7 +729,7 @@ if(WITH_RADOSGW AND WITH_RADOSGW_LUA_PACKAGES) list(APPEND BOOST_COMPONENTS filesystem) endif() -if(WITH_LIBCEPHFS) +if(WITH_LIBCEPHFS OR WITH_FUSE) find_package(ICU REQUIRED COMPONENTS uc i18n) list(APPEND BOOST_COMPONENTS locale) endif() diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index afa13b79288eb..d1ff371d50a39 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -833,7 +833,10 @@ install(PROGRAMS DESTINATION sbin) add_subdirectory(bash_completion) -add_subdirectory(client) + +if(WITH_LIBCEPHFS OR WITH_FUSE) + add_subdirectory(client) +endif() if(WITH_LIBCEPHFS) set(libcephfs_srcs libcephfs.cc) -- 2.39.5