From 73479a1e055ade66bb7f6221fd4bbb5f3329125c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Wed, 22 Jun 2022 21:24:12 -0400 Subject: [PATCH] dashboard: fix spelling errors * access * availability * dashboard * depth * dimless * evaluation * executing * existing * facts * gigabytes * idempotent * independent * initial * inventory * managed * must not * notification * notifications * orchestrator * previously * promises * purging * queried * repetitive * split * subdirectories * tenant * the * timestamp * transformed * unavailable * visibility * yourself Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- monitoring/ceph-mixin/prometheus_alerts.libsonnet | 4 ++-- monitoring/ceph-mixin/prometheus_alerts.yml | 6 +++--- monitoring/ceph-mixin/tests_alerts/test_alerts.yml | 10 +++++----- .../tests_dashboards/features/environment.py | 2 +- monitoring/ceph-mixin/tests_dashboards/util.py | 2 +- qa/tasks/mgr/dashboard/test_rbd_mirroring.py | 2 +- qa/tasks/mgr/dashboard/test_user.py | 2 +- .../mgr/dashboard/ci/check_grafana_dashboards.py | 2 +- src/pybind/mgr/dashboard/controllers/_crud.py | 2 +- src/pybind/mgr/dashboard/controllers/cephfs.py | 2 +- src/pybind/mgr/dashboard/controllers/host.py | 2 +- .../dashboard/frontend/cypress/e2e/block/images.po.ts | 2 +- .../cypress/e2e/orchestrator/01-hosts.e2e-spec.ts | 2 +- .../workflow/02-create-cluster-add-host.feature | 2 +- .../dashboard/frontend/cypress/e2e/rgw/buckets.po.ts | 2 +- .../mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts | 2 +- .../frontend/cypress/e2e/ui/notification.e2e-spec.ts | 2 +- .../frontend/cypress/e2e/ui/notification.po.ts | 8 ++++---- .../rbd-namespace-list/rbd-namespace-list.component.ts | 8 ++++---- .../cephfs-directories/cephfs-directories.component.ts | 4 ++-- .../src/app/ceph/cluster/hosts/hosts.component.spec.ts | 4 ++-- .../ceph/pool/pool-form/pool-form.component.spec.ts | 2 +- .../rgw-bucket-list/rgw-bucket-list.component.spec.ts | 2 +- .../rgw/rgw-user-list/rgw-user-list.component.spec.ts | 2 +- .../fixtures/smart_data_version_1_0_nvme_response.json | 2 +- .../app/ceph/shared/smart-list/smart-list.component.ts | 2 +- .../notifications-sidebar.component.ts | 4 ++-- .../src/app/shared/forms/cd-validators.spec.ts | 2 +- .../frontend/src/app/shared/models/image-spec.ts | 8 ++++---- .../frontend/src/app/shared/pipes/duration.pipe.ts | 2 +- ...sibilty.operator.ts => page-visibility.operator.ts} | 0 .../app/shared/services/motd-notification.service.ts | 2 +- .../frontend/src/app/shared/services/timer.service.ts | 2 +- src/pybind/mgr/dashboard/services/iscsi_config.py | 2 +- src/pybind/mgr/dashboard/tests/__init__.py | 2 +- src/pybind/mgr/dashboard/tests/test_osd.py | 4 ++-- 36 files changed, 55 insertions(+), 55 deletions(-) rename src/pybind/mgr/dashboard/frontend/src/app/shared/rxjs/operators/{page-visibilty.operator.ts => page-visibility.operator.ts} (100%) diff --git a/monitoring/ceph-mixin/prometheus_alerts.libsonnet b/monitoring/ceph-mixin/prometheus_alerts.libsonnet index b7ec0da2f04..2cf5568fb8f 100644 --- a/monitoring/ceph-mixin/prometheus_alerts.libsonnet +++ b/monitoring/ceph-mixin/prometheus_alerts.libsonnet @@ -442,7 +442,7 @@ }, }, { - alert: 'CephPGUnavilableBlockingIO', + alert: 'CephPGUnavailableBlockingIO', 'for': '1m', expr: '((ceph_health_detail{name="PG_AVAILABILITY"} == 1) - scalar(ceph_health_detail{name="OSD_DOWN"})) == 1', labels: { severity: 'critical', type: 'ceph_default', oid: '1.3.6.1.4.1.50495.1.2.1.7.3' }, @@ -672,7 +672,7 @@ expr: 'ceph_health_detail{name="CEPHADM_FAILED_DAEMON"} > 0', labels: { severity: 'critical', type: 'ceph_default', oid: '1.3.6.1.4.1.50495.1.2.1.11.1' }, annotations: { - summary: 'A ceph daemon manged by cephadm is down%(cluster)s' % $.MultiClusterSummary(), + summary: 'A ceph daemon managed by cephadm is down%(cluster)s' % $.MultiClusterSummary(), description: "A daemon managed by cephadm is no longer active. Determine, which daemon is down with 'ceph health detail'. you may start daemons with the 'ceph orch daemon start '", }, }, diff --git a/monitoring/ceph-mixin/prometheus_alerts.yml b/monitoring/ceph-mixin/prometheus_alerts.yml index 4a3e6acf389..ae846dc3b84 100644 --- a/monitoring/ceph-mixin/prometheus_alerts.yml +++ b/monitoring/ceph-mixin/prometheus_alerts.yml @@ -196,7 +196,7 @@ groups: type: "ceph_default" - alert: "CephDeviceFailurePredictionTooHigh" annotations: - description: "The device health module has determined that devices predicted to fail can not be remediated automatically, since too many OSDs would be removed from the cluster to ensure performance and availabililty. Prevent data integrity issues by adding new OSDs so that data may be relocated." + description: "The device health module has determined that devices predicted to fail can not be remediated automatically, since too many OSDs would be removed from the cluster to ensure performance and availability. Prevent data integrity issues by adding new OSDs so that data may be relocated." documentation: "https://docs.ceph.com/en/latest/rados/operations/health-checks#device-health-toomany" summary: "Too many devices are predicted to fail, unable to resolve" expr: "ceph_health_detail{name=\"DEVICE_HEALTH_TOOMANY\"} == 1" @@ -393,7 +393,7 @@ groups: oid: "1.3.6.1.4.1.50495.1.2.1.7.5" severity: "critical" type: "ceph_default" - - alert: "CephPGUnavilableBlockingIO" + - alert: "CephPGUnavailableBlockingIO" annotations: description: "Data availability is reduced, impacting the cluster's ability to service I/O. One or more placement groups (PGs) are in a state that blocks I/O." documentation: "https://docs.ceph.com/en/latest/rados/operations/health-checks#pg-availability" @@ -597,7 +597,7 @@ groups: - alert: "CephadmDaemonFailed" annotations: description: "A daemon managed by cephadm is no longer active. Determine, which daemon is down with 'ceph health detail'. you may start daemons with the 'ceph orch daemon start '" - summary: "A ceph daemon manged by cephadm is down" + summary: "A ceph daemon managed by cephadm is down" expr: "ceph_health_detail{name=\"CEPHADM_FAILED_DAEMON\"} > 0" for: "30s" labels: diff --git a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml index 1aaea88e7f5..73cfa7996cf 100644 --- a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml +++ b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml @@ -784,7 +784,7 @@ tests: type: ceph_default oid: 1.3.6.1.4.1.50495.1.2.1.11.1 exp_annotations: - summary: A ceph daemon manged by cephadm is down + summary: A ceph daemon managed by cephadm is down description: "A daemon managed by cephadm is no longer active. Determine, which daemon is down with 'ceph health detail'. you may start daemons with the 'ceph orch daemon start '" - interval: 1m input_series: @@ -1243,7 +1243,7 @@ tests: exp_annotations: documentation: https://docs.ceph.com/en/latest/rados/operations/health-checks#device-health-toomany summary: Too many devices are predicted to fail, unable to resolve - description: "The device health module has determined that devices predicted to fail can not be remediated automatically, since too many OSDs would be removed from the cluster to ensure performance and availabililty. Prevent data integrity issues by adding new OSDs so that data may be relocated." + description: "The device health module has determined that devices predicted to fail can not be remediated automatically, since too many OSDs would be removed from the cluster to ensure performance and availability. Prevent data integrity issues by adding new OSDs so that data may be relocated." - interval: 1m input_series: - series: 'ceph_health_detail{name="DEVICE_HEALTH_IN_USE"}' @@ -1754,15 +1754,15 @@ tests: alert_rule_test: # PG_AVAILABILITY and OSD_DOWN not firing .. no alert - eval_time: 1m - alertname: CephPGUnavilableBlockingIO + alertname: CephPGUnavailableBlockingIO exp_alerts: # PG_AVAILABILITY firing, but osd_down is active .. no alert - eval_time: 5m - alertname: CephPGUnavilableBlockingIO + alertname: CephPGUnavailableBlockingIO exp_alerts: # PG_AVAILABILITY firing, AND OSD_DOWN is not active...raise the alert - eval_time: 15m - alertname: CephPGUnavilableBlockingIO + alertname: CephPGUnavailableBlockingIO exp_alerts: - exp_labels: name: "PG_AVAILABILITY" diff --git a/monitoring/ceph-mixin/tests_dashboards/features/environment.py b/monitoring/ceph-mixin/tests_dashboards/features/environment.py index 5dc76a09e41..aa040ef9411 100644 --- a/monitoring/ceph-mixin/tests_dashboards/features/environment.py +++ b/monitoring/ceph-mixin/tests_dashboards/features/environment.py @@ -93,7 +93,7 @@ def step_impl(context, interval): def step_impl(context, eval_time): eval_time_without_unit, unit = resolve_time_and_unit(eval_time) if eval_time_without_unit is None: - raise ValueError(f'Invalid evalution time: {eval_time}. ' + + raise ValueError(f'Invalid evaluation time: {eval_time}. ' + 'A valid time looks like "1m" where you have a number plus a unit') global_context.promql_expr_test.set_eval_time(eval_time_without_unit, unit) diff --git a/monitoring/ceph-mixin/tests_dashboards/util.py b/monitoring/ceph-mixin/tests_dashboards/util.py index 1fce6559dfb..835dedee7eb 100644 --- a/monitoring/ceph-mixin/tests_dashboards/util.py +++ b/monitoring/ceph-mixin/tests_dashboards/util.py @@ -85,7 +85,7 @@ def add_default_dashboards_variables(data: Dict[str, Any]) -> None: def replace_grafana_expr_variables(expr: str, variable: str, value: Any) -> str: """ Replace grafana variables in expression with a value - It should match the whole word, 'osd' musn't match with the 'osd' prefix in 'osd_hosts' + It should match the whole word, 'osd' must not match with the 'osd' prefix in 'osd_hosts' >>> replace_grafana_expr_variables('metric{name~="$osd_hosts|$other|$osd"}', \ 'osd', 'replacement') 'metric{name~="$osd_hosts|$other|replacement"}' diff --git a/qa/tasks/mgr/dashboard/test_rbd_mirroring.py b/qa/tasks/mgr/dashboard/test_rbd_mirroring.py index b6a86e40563..d868950cff9 100644 --- a/qa/tasks/mgr/dashboard/test_rbd_mirroring.py +++ b/qa/tasks/mgr/dashboard/test_rbd_mirroring.py @@ -189,7 +189,7 @@ class RbdMirroringTest(DashboardTestCase): self._task_post('/api/block/mirroring/pool/rbd/bootstrap/peer', import_data) self.assertStatus(400) - # cannot import "youself" as peer + # cannot import "yourself" as peer import_data['direction'] = 'rx' self._task_post('/api/block/mirroring/pool/rbd/bootstrap/peer', import_data) self.assertStatus(400) diff --git a/qa/tasks/mgr/dashboard/test_user.py b/qa/tasks/mgr/dashboard/test_user.py index 3a6464f5a5b..da958900ff4 100644 --- a/qa/tasks/mgr/dashboard/test_user.py +++ b/qa/tasks/mgr/dashboard/test_user.py @@ -271,7 +271,7 @@ class UserTest(DashboardTestCase): 'Password must not contain sequential characters.') self._reset_login_to_admin('test1') - def test_change_password_contains_repetetive_characters(self): + def test_change_password_contains_repetitive_characters(self): self.create_user('test1', 'mypassword10#', ['read-only'], force_password=False) self.login('test1', 'mypassword10#') self._post('/api/user/test1/change_password', { diff --git a/src/pybind/mgr/dashboard/ci/check_grafana_dashboards.py b/src/pybind/mgr/dashboard/ci/check_grafana_dashboards.py index d37337b404e..317dc45ce2e 100644 --- a/src/pybind/mgr/dashboard/ci/check_grafana_dashboards.py +++ b/src/pybind/mgr/dashboard/ci/check_grafana_dashboards.py @@ -77,7 +77,7 @@ def get_grafana_dashboards(base_dir): dashboard_config = json.load(f) uid = dashboard_config.get('uid') # if it's not a grafana dashboard, skip checks - # Fields in a dasbhoard: + # Fields in a dashboard: # https://grafana.com/docs/grafana/latest/dashboards/json-model/#json-fields expected_fields = [ 'id', 'uid', 'title', 'tags', 'style', 'timezone', 'editable', diff --git a/src/pybind/mgr/dashboard/controllers/_crud.py b/src/pybind/mgr/dashboard/controllers/_crud.py index 4a57ac06cc5..240a2b5ab8c 100644 --- a/src/pybind/mgr/dashboard/controllers/_crud.py +++ b/src/pybind/mgr/dashboard/controllers/_crud.py @@ -155,7 +155,7 @@ class Container: raise NotImplementedError def to_dict(self, key=''): - # intialize the schema of this container + # initialize the schema of this container ui_schemas = [] control_schema = { 'type': self._property_type(), diff --git a/src/pybind/mgr/dashboard/controllers/cephfs.py b/src/pybind/mgr/dashboard/controllers/cephfs.py index 69de90f3780..abb68039738 100644 --- a/src/pybind/mgr/dashboard/controllers/cephfs.py +++ b/src/pybind/mgr/dashboard/controllers/cephfs.py @@ -328,7 +328,7 @@ class CephFS(RESTController): "No cephfs with id {0}".format(fs_id)) # Decorate the metadata with some fields that will be - # indepdendent of whether it's a kernel or userspace + # independent of whether it's a kernel or userspace # client, so that the javascript doesn't have to grok that. for client in clients: if "ceph_version" in client['client_metadata']: # pragma: no cover - no complexity diff --git a/src/pybind/mgr/dashboard/controllers/host.py b/src/pybind/mgr/dashboard/controllers/host.py index 812b9c035ae..c0062b94d70 100644 --- a/src/pybind/mgr/dashboard/controllers/host.py +++ b/src/pybind/mgr/dashboard/controllers/host.py @@ -226,7 +226,7 @@ def get_inventories(hosts: Optional[List[str]] = None, :param hosts: Hostnames to query. :param refresh: Ask the Orchestrator to refresh the inventories. Note the this is an asynchronous operation, the updated version of inventories need to - be re-qeuried later. + be re-queried later. :return: Returns list of inventory. :rtype: list """ diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/block/images.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/block/images.po.ts index bf6cbc05263..89927305d10 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/block/images.po.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/block/images.po.ts @@ -97,7 +97,7 @@ export class ImagesPageHelper extends PageHelper { // Check for visibility of modal container cy.get('.modal-header').should('be.visible'); - // If purgeing a specific pool, selects that pool if given + // If purging a specific pool, selects that pool if given if (pool !== undefined) { this.selectOption('poolName', pool); cy.get('#poolName').should('have.class', 'ng-valid'); // check if pool is selected diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/01-hosts.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/01-hosts.e2e-spec.ts index 8ad2a1dafda..c7ac2c485d0 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/01-hosts.e2e-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/01-hosts.e2e-spec.ts @@ -14,7 +14,7 @@ describe('Hosts page', () => { cy.fixture('orchestrator/services.json').as('services'); }); - it('should not add an exsiting host', function () { + it('should not add an existing host', function () { const hostname = Cypress._.sample(this.hosts).name; hosts.navigateTo('add'); hosts.add(hostname, true); diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/02-create-cluster-add-host.feature b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/02-create-cluster-add-host.feature index be49fcba099..a71cdb79282 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/02-create-cluster-add-host.feature +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/orchestrator/workflow/02-create-cluster-add-host.feature @@ -51,7 +51,7 @@ Feature: Cluster expansion host addition | ceph-node-01 | | ceph-node-02 | - Scenario: Add exisiting host and verify it failed + Scenario: Add existing host and verify it failed Given I am on the "Add Hosts" section And I should see a row with "ceph-node-00" When I click on "Add" button diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/buckets.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/buckets.po.ts index a27be3c6ba4..93b77fe6bbc 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/buckets.po.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/buckets.po.ts @@ -162,7 +162,7 @@ export class BucketsPageHelper extends PageHelper { // Check invalid placement target input this.selectOwner(BucketsPageHelper.USERS[1]); - // The drop down error message will not appear unless a valid option is previsously selected. + // The drop down error message will not appear unless a valid option is previously selected. this.selectPlacementTarget('default-placement'); this.selectPlacementTarget('-- Select a placement target --'); cy.get('@nameInputField').click(); // Trigger validation diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts index 980cced8807..3cffa08ce27 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/rgw/users.po.ts @@ -12,7 +12,7 @@ export class UsersPageHelper extends PageHelper { create(tenant: string, user_id: string, fullname: string, email: string, maxbuckets: string) { // Enter in user_id cy.get('#user_id').type(user_id); - // Show Tenanat + // Show Tenant cy.get('#show_tenant').click({ force: true }); // Enter in tenant cy.get('#tenant').type(tenant); diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.e2e-spec.ts index b69f26f58dc..8e2d621fe14 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.e2e-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.e2e-spec.ts @@ -50,7 +50,7 @@ describe('Notification page', () => { notification.getToast().should('not.exist'); notification.open(); notification.getNotifications().should('have.length.gt', 0); - notification.getClearNotficationsBtn().should('be.visible'); + notification.getClearNotificationsBtn().should('be.visible'); notification.clearNotifications(); }); }); diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.po.ts index 12c424e350d..47f333b6458 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.po.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/ui/notification.po.ts @@ -1,7 +1,7 @@ import { PageHelper } from '../page-helper.po'; export class NotificationSidebarPageHelper extends PageHelper { - getNotificatinoIcon() { + getNotificationIcon() { return cy.get('cd-notifications a'); } @@ -17,7 +17,7 @@ export class NotificationSidebarPageHelper extends PageHelper { return this.getSidebar().find('.card.tc_notification'); } - getClearNotficationsBtn() { + getClearNotificationsBtn() { return this.getSidebar().find('button.btn-block'); } @@ -26,14 +26,14 @@ export class NotificationSidebarPageHelper extends PageHelper { } open() { - this.getNotificatinoIcon().click(); + this.getNotificationIcon().click(); this.getSidebar().should('be.visible'); } clearNotifications() { // It can happen that although notifications are cleared, by the time we check the notifications // amount, another notification can appear, so we check it more than once (if needed). - this.getClearNotficationsBtn().click(); + this.getClearNotificationsBtn().click(); this.getNotifications() .should('have.length.gte', 0) .then(($elems) => { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-namespace-list/rbd-namespace-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-namespace-list/rbd-namespace-list.component.ts index 4617e13e424..8e7812d7194 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-namespace-list/rbd-namespace-list.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-namespace-list/rbd-namespace-list.component.ts @@ -84,12 +84,12 @@ export class RbdNamespaceListComponent implements OnInit { pools = pools.filter( (pool: any) => this.rbdService.isRBDPool(pool) && pool.type === 'replicated' ); - const promisses: Observable[] = []; + const promises: Observable[] = []; pools.forEach((pool: any) => { - promisses.push(this.rbdService.listNamespaces(pool['pool_name'])); + promises.push(this.rbdService.listNamespaces(pool['pool_name'])); }); - if (promisses.length > 0) { - forkJoin(promisses).subscribe((data: Array>) => { + if (promises.length > 0) { + forkJoin(promises).subscribe((data: Array>) => { const result: any[] = []; for (let i = 0; i < data.length; i++) { const namespaces = data[i]; diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-directories/cephfs-directories.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-directories/cephfs-directories.component.ts index 841d635b1a0..9fd445dc23d 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-directories/cephfs-directories.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-directories/cephfs-directories.component.ts @@ -242,7 +242,7 @@ export class CephfsDirectoriesComponent implements OnInit, OnChanges { private disableCreateSnapshot(): string | boolean { const folders = this.selectedDir.path.split('/').slice(1); - // With deph of 4 or more we have the subvolume files/folders for which we cannot create + // With depth of 4 or more we have the subvolume files/folders for which we cannot create // a snapshot. Somehow, you can create a snapshot of the subvolume but not its files. if (folders.length >= 4 && folders[0] === 'volumes') { return $localize`Cannot create snapshots for files/folders in the subvolume ${folders[2]}`; @@ -645,7 +645,7 @@ export class CephfsDirectoriesComponent implements OnInit, OnChanges { } const node = this.getNode(parent); if (!node) { - // Node will not be found for new sub sub directories - this is the intended behaviour + // Node will not be found for new sub directories - this is the intended behaviour return; } const children = this.getChildren(parent); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.spec.ts index 43be6e8c758..6c9311cbeb8 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.spec.ts @@ -162,7 +162,7 @@ describe('HostsComponent', () => { expect(spans[2].textContent).toContain('rgw: 1'); }); - it('should test if host facts are tranformed correctly if orch available', () => { + it('should test if host facts are transformed correctly if orch available', () => { const features = [OrchestratorFeature.HOST_FACTS]; const payload = [ { @@ -227,7 +227,7 @@ describe('HostsComponent', () => { expect(spans[7].textContent).toBe('N/A'); }); - it('should test if host facts are unavailable if get_fatcs orch feature is not available', () => { + it('should test if host facts are unavailable if get_facts orch feature is not available', () => { const payload = [ { hostname: 'host_test', diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.spec.ts index 87b791b6903..7e2bccb32dd 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.spec.ts @@ -528,7 +528,7 @@ describe('PoolFormComponent', () => { expect(component.getMaxSize()).toBe(3); }); - it('should return the osd count as minimum if its lower the the rule minimum', () => { + it('should return the osd count as minimum if its lower the rule minimum', () => { component.info.osd_count = 0; formHelper.setValue('crushRule', component.info.crush_rules_replicated[0]); const control = form.get('crushRule'); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts index ff070579317..58d6fa983d3 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts @@ -87,7 +87,7 @@ describe('RgwBucketListComponent', () => { }); }); - it('should test if bucket data is tranformed correctly', () => { + it('should test if bucket data is transformed correctly', () => { rgwBucketServiceListSpy.and.returnValue( of([ { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.spec.ts index 2f886ccf5d4..6d30c5b7294 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.spec.ts @@ -81,7 +81,7 @@ describe('RgwUserListComponent', () => { }); }); - it('should test if rgw-user data is tranformed correctly', () => { + it('should test if rgw-user data is transformed correctly', () => { rgwUserServiceListSpy.and.returnValue( of([ { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/fixtures/smart_data_version_1_0_nvme_response.json b/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/fixtures/smart_data_version_1_0_nvme_response.json index fce50658a44..e339ab819dc 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/fixtures/smart_data_version_1_0_nvme_response.json +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/fixtures/smart_data_version_1_0_nvme_response.json @@ -79,7 +79,7 @@ "Local Time is: Thu Oct 24 10:17:06 2019 CEST", "Firmware Updates (0x16): 3 Slots, no Reset required", "Optional Admin Commands (0x0017): Security Format Frmw_DL Self_Test", - "Optional NVM Commands (0x005f): Comp Wr_Unc DS_Mngmt Wr_Zero Sav/Sel_Feat Timestmp", + "Optional NVM Commands (0x005f): Comp Wr_Unc DS_Mngmt Wr_Zero Sav/Sel_Feat Timestamp", "Maximum Data Transfer Size: 512 Pages", "Warning Comp. Temp. Threshold: 85 Celsius", "Critical Comp. Temp. Threshold: 85 Celsius", diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/smart-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/smart-list.component.ts index abfdcfe5be5..3ad0a8c564d 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/smart-list.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/smart-list/smart-list.component.ts @@ -194,7 +194,7 @@ smartmontools is required to successfully retrieve data.`; prop: 'errors_corrected_by_rereads_rewrites', name: $localize`Errors Corrected by Rereads/Rewrites` }, - { prop: 'gigabytes_processed', name: $localize`Gigabyes Processed` }, + { prop: 'gigabytes_processed', name: $localize`Gigabytes Processed` }, { prop: 'total_errors_corrected', name: $localize`Total Errors Corrected` }, { prop: 'total_uncorrected_errors', name: $localize`Total Errors Uncorrected` } ]; diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/notifications-sidebar/notifications-sidebar.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/notifications-sidebar/notifications-sidebar.component.ts index 39369ffd5be..3868f55ba53 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/notifications-sidebar/notifications-sidebar.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/notifications-sidebar/notifications-sidebar.component.ts @@ -147,8 +147,8 @@ export class NotificationsSidebarComponent implements OnInit, OnDestroy { } _handleTasks(executingTasks: ExecutingTask[]) { - for (const excutingTask of executingTasks) { - excutingTask.description = this.taskMessageService.getRunningTitle(excutingTask); + for (const executingTask of executingTasks) { + executingTask.description = this.taskMessageService.getRunningTitle(executingTask); } this.executingTasks = executingTasks; } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-validators.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-validators.spec.ts index 5cf90fdea5c..a0954990be5 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-validators.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-validators.spec.ts @@ -608,7 +608,7 @@ describe('CdValidators', () => { }); }); - describe('dimmlessBinary validators', () => { + describe('dimlessBinary validators', () => { const i18nMock = (a: string, b: { value: string }) => a.replace('{{value}}', b.value); beforeEach(() => { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/models/image-spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/models/image-spec.ts index 8b56b291c73..c6260011a9f 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/models/image-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/models/image-spec.ts @@ -1,10 +1,10 @@ export class ImageSpec { static fromString(imageSpec: string) { - const imageSpecSplited = imageSpec.split('/'); + const imageSpecSplit = imageSpec.split('/'); - const poolName = imageSpecSplited[0]; - const namespace = imageSpecSplited.length >= 3 ? imageSpecSplited[1] : null; - const imageName = imageSpecSplited.length >= 3 ? imageSpecSplited[2] : imageSpecSplited[1]; + const poolName = imageSpecSplit[0]; + const namespace = imageSpecSplit.length >= 3 ? imageSpecSplit[1] : null; + const imageName = imageSpecSplit.length >= 3 ? imageSpecSplit[2] : imageSpecSplit[1]; return new this(poolName, namespace, imageName); } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/pipes/duration.pipe.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/pipes/duration.pipe.ts index 687153b21b6..0a9507a1827 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/pipes/duration.pipe.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/pipes/duration.pipe.ts @@ -10,7 +10,7 @@ export class DurationPipe implements PipeTransform { * source: https://stackoverflow.com/a/34270811 * * @param {number} seconds The number of seconds to be processed - * @return {string} The phrase describing the the amount of time + * @return {string} The phrase describing the amount of time */ transform(seconds: number): string { if (seconds === null || seconds <= 0) { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/rxjs/operators/page-visibilty.operator.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/rxjs/operators/page-visibility.operator.ts similarity index 100% rename from src/pybind/mgr/dashboard/frontend/src/app/shared/rxjs/operators/page-visibilty.operator.ts rename to src/pybind/mgr/dashboard/frontend/src/app/shared/rxjs/operators/page-visibility.operator.ts diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/motd-notification.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/motd-notification.service.ts index d2ee89f9cd1..c2602204c43 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/motd-notification.service.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/motd-notification.service.ts @@ -5,7 +5,7 @@ import { BehaviorSubject, EMPTY, Observable, of, Subscription } from 'rxjs'; import { catchError, delay, mergeMap, repeat, tap } from 'rxjs/operators'; import { Motd, MotdService } from '~/app/shared/api/motd.service'; -import { whenPageVisible } from '../rxjs/operators/page-visibilty.operator'; +import { whenPageVisible } from '../rxjs/operators/page-visibility.operator'; @Injectable({ providedIn: 'root' diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/timer.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/timer.service.ts index 716b710968f..f1c38e38a97 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/timer.service.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/timer.service.ts @@ -3,7 +3,7 @@ import { Injectable } from '@angular/core'; import { Observable, timer } from 'rxjs'; import { observeOn, shareReplay, switchMap } from 'rxjs/operators'; -import { whenPageVisible } from '../rxjs/operators/page-visibilty.operator'; +import { whenPageVisible } from '../rxjs/operators/page-visibility.operator'; import { NgZoneSchedulerService } from './ngzone-scheduler.service'; @Injectable({ diff --git a/src/pybind/mgr/dashboard/services/iscsi_config.py b/src/pybind/mgr/dashboard/services/iscsi_config.py index c1898a463ca..492afa94774 100644 --- a/src/pybind/mgr/dashboard/services/iscsi_config.py +++ b/src/pybind/mgr/dashboard/services/iscsi_config.py @@ -67,7 +67,7 @@ class IscsiGatewaysConfig(object): del config['gateways'][gateway_name] cls._save_config(config) except RequestException: - # If gateway is not acessible, it should be removed manually + # If gateway is not accessible, it should be removed manually # or we will try to update automatically next time continue diff --git a/src/pybind/mgr/dashboard/tests/__init__.py b/src/pybind/mgr/dashboard/tests/__init__.py index 51d233208b9..ece3ef721bf 100644 --- a/src/pybind/mgr/dashboard/tests/__init__.py +++ b/src/pybind/mgr/dashboard/tests/__init__.py @@ -120,7 +120,7 @@ class ControllerTestCase(helper.CPWebCase): inst = ctrl() # We need to cache the controller endpoints because - # BaseController#endpoints method is not idempontent + # BaseController#endpoints method is not idempotent # and a controller might be needed by more than one # unit test. if ctrl not in cls._endpoints_cache: diff --git a/src/pybind/mgr/dashboard/tests/test_osd.py b/src/pybind/mgr/dashboard/tests/test_osd.py index 144a98e49af..c3cd0dca88d 100644 --- a/src/pybind/mgr/dashboard/tests/test_osd.py +++ b/src/pybind/mgr/dashboard/tests/test_osd.py @@ -196,7 +196,7 @@ class OsdHelper(object): self.available = available self.path = path - def create_invetory_host(host, devices_data): + def create_inventory_host(host, devices_data): inventory_host = mock.Mock() inventory_host.devices.devices = [] for data in devices_data: @@ -209,7 +209,7 @@ class OsdHelper(object): for device in devices_data: hosts.add(device['host']) - inventory = [create_invetory_host(host, devices_data) for host in hosts] + inventory = [create_inventory_host(host, devices_data) for host in hosts] orch_client_mock.inventory.list.return_value = inventory -- 2.39.5