From 73a014fc2ca928eb72def31c9e4177063cda421a Mon Sep 17 00:00:00 2001 From: Greg Farnum Date: Wed, 12 Aug 2020 23:44:11 +0000 Subject: [PATCH] mon: mark pgtemp messages as no_reply more consistently in preprocess_pgtemp If a message is forwarded, it's conceivable the leader's and peon's evaluation will disagree about whether the message is useful or not, which could result in the leader ignoring it and the peon having a dangling forwarded message. Fix this by marking the op as no_reply whenever ignoring it. Fixes: https://tracker.ceph.com/issues/46914 Signed-off-by: Greg Farnum --- src/mon/OSDMonitor.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 41dc08c48e45b..70d2f7cae45f4 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -4083,6 +4083,7 @@ bool OSDMonitor::preprocess_pgtemp(MonOpRequestRef op) return true; ignore: + mon->no_reply(op); return true; } -- 2.39.5