From 73c4a10d700d45fbc8026c86c0ad91db4d08d3f5 Mon Sep 17 00:00:00 2001 From: Avan Thakkar Date: Wed, 8 Jun 2022 16:33:18 +0530 Subject: [PATCH] mgr/dashboard: fix mirroring e2e and lint errors Signed-off-by: Avan Thakkar --- .../cypress/integration/block/mirroring.e2e-spec.ts | 6 +++--- .../block/mirroring/image-list/image-list.component.html | 2 +- .../block/mirroring/image-list/image-list.component.ts | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/cypress/integration/block/mirroring.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/integration/block/mirroring.e2e-spec.ts index 120956579d8d1..dfba73b27409d 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/integration/block/mirroring.e2e-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/integration/block/mirroring.e2e-spec.ts @@ -20,9 +20,9 @@ describe('Mirroring page', () => { }); it('should show text for all tabs', () => { - mirroring.getTabText(0).should('eq', 'Issues'); - mirroring.getTabText(1).should('eq', 'Syncing'); - mirroring.getTabText(2).should('eq', 'Ready'); + mirroring.getTabText(0).should('eq', 'Issues (0)'); + mirroring.getTabText(1).should('eq', 'Syncing (0)'); + mirroring.getTabText(2).should('eq', 'Ready (0)'); }); describe('checks that edit mode functionality shows in the pools table', () => { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.html index a9547a10bc4af..d4972a41c1353 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.html @@ -57,7 +57,7 @@
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.ts index 00fe91338fa24..4966cc0af5dcc 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/image-list/image-list.component.ts @@ -47,13 +47,13 @@ export class ImageListComponent implements OnInit, OnDestroy { cellTemplate: this.stateTmpl, flexGrow: 1 }, - { prop: 'description', name: $localize`Issue`, flexGrow: 4 }, + { prop: 'description', name: $localize`Issue`, flexGrow: 4 } ]; this.image_syncing.columns = [ { prop: 'pool_name', name: $localize`Pool`, flexGrow: 2 }, { prop: 'name', name: $localize`Image`, flexGrow: 2 }, - { + { prop: 'state', name: $localize`State`, cellTemplate: this.stateTmpl, @@ -66,7 +66,7 @@ export class ImageListComponent implements OnInit, OnDestroy { flexGrow: 2 }, { prop: 'bytes_per_second', name: $localize`Bytes per second`, flexGrow: 2 }, - { prop: 'entries_behind_primary', name: $localize`Entries behind primary`, flexGrow: 2 }, + { prop: 'entries_behind_primary', name: $localize`Entries behind primary`, flexGrow: 2 } ]; this.image_ready.columns = [ @@ -78,7 +78,7 @@ export class ImageListComponent implements OnInit, OnDestroy { cellTemplate: this.stateTmpl, flexGrow: 1 }, - { prop: 'description', name: $localize`Description`, flexGrow: 4 }, + { prop: 'description', name: $localize`Description`, flexGrow: 4 } ]; this.subs = this.rbdMirroringService.subscribeSummary((data) => { -- 2.39.5