From 73ff298b898ca76e3f9b615449b4e4c0f2d0c017 Mon Sep 17 00:00:00 2001 From: Chang Liu Date: Tue, 23 Jan 2018 15:39:56 +0800 Subject: [PATCH] mon: use pool_sum as param name in PGMapDigest::recovery_summary the param name of delta_sum of PGMapDigest::recovery_summary() is misleading too. delta_sum fits the recovery_rate_summary() well, but not recovery_summary(). Signed-off-by: Chang Liu --- src/mon/PGMap.cc | 44 ++++++++++++++++++++++---------------------- src/mon/PGMap.h | 2 +- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc index 2c50220151e..cfa2c448b47 100644 --- a/src/mon/PGMap.cc +++ b/src/mon/PGMap.cc @@ -392,53 +392,53 @@ void PGMapDigest::print_oneline_summary(Formatter *f, ostream *out) const } void PGMapDigest::recovery_summary(Formatter *f, list *psl, - const pool_stat_t& delta_sum) const + const pool_stat_t& pool_sum) const { - if (delta_sum.stats.sum.num_objects_degraded && delta_sum.stats.sum.num_object_copies > 0) { - double pc = (double)delta_sum.stats.sum.num_objects_degraded / - (double)delta_sum.stats.sum.num_object_copies * (double)100.0; + if (pool_sum.stats.sum.num_objects_degraded && pool_sum.stats.sum.num_object_copies > 0) { + double pc = (double)pool_sum.stats.sum.num_objects_degraded / + (double)pool_sum.stats.sum.num_object_copies * (double)100.0; char b[20]; snprintf(b, sizeof(b), "%.3lf", pc); if (f) { - f->dump_unsigned("degraded_objects", delta_sum.stats.sum.num_objects_degraded); - f->dump_unsigned("degraded_total", delta_sum.stats.sum.num_object_copies); + f->dump_unsigned("degraded_objects", pool_sum.stats.sum.num_objects_degraded); + f->dump_unsigned("degraded_total", pool_sum.stats.sum.num_object_copies); f->dump_float("degraded_ratio", pc / 100.0); } else { ostringstream ss; - ss << delta_sum.stats.sum.num_objects_degraded - << "/" << delta_sum.stats.sum.num_object_copies << " objects degraded (" << b << "%)"; + ss << pool_sum.stats.sum.num_objects_degraded + << "/" << pool_sum.stats.sum.num_object_copies << " objects degraded (" << b << "%)"; psl->push_back(ss.str()); } } - if (delta_sum.stats.sum.num_objects_misplaced && delta_sum.stats.sum.num_object_copies > 0) { - double pc = (double)delta_sum.stats.sum.num_objects_misplaced / - (double)delta_sum.stats.sum.num_object_copies * (double)100.0; + if (pool_sum.stats.sum.num_objects_misplaced && pool_sum.stats.sum.num_object_copies > 0) { + double pc = (double)pool_sum.stats.sum.num_objects_misplaced / + (double)pool_sum.stats.sum.num_object_copies * (double)100.0; char b[20]; snprintf(b, sizeof(b), "%.3lf", pc); if (f) { - f->dump_unsigned("misplaced_objects", delta_sum.stats.sum.num_objects_misplaced); - f->dump_unsigned("misplaced_total", delta_sum.stats.sum.num_object_copies); + f->dump_unsigned("misplaced_objects", pool_sum.stats.sum.num_objects_misplaced); + f->dump_unsigned("misplaced_total", pool_sum.stats.sum.num_object_copies); f->dump_float("misplaced_ratio", pc / 100.0); } else { ostringstream ss; - ss << delta_sum.stats.sum.num_objects_misplaced - << "/" << delta_sum.stats.sum.num_object_copies << " objects misplaced (" << b << "%)"; + ss << pool_sum.stats.sum.num_objects_misplaced + << "/" << pool_sum.stats.sum.num_object_copies << " objects misplaced (" << b << "%)"; psl->push_back(ss.str()); } } - if (delta_sum.stats.sum.num_objects_unfound && delta_sum.stats.sum.num_objects) { - double pc = (double)delta_sum.stats.sum.num_objects_unfound / - (double)delta_sum.stats.sum.num_objects * (double)100.0; + if (pool_sum.stats.sum.num_objects_unfound && pool_sum.stats.sum.num_objects) { + double pc = (double)pool_sum.stats.sum.num_objects_unfound / + (double)pool_sum.stats.sum.num_objects * (double)100.0; char b[20]; snprintf(b, sizeof(b), "%.3lf", pc); if (f) { - f->dump_unsigned("unfound_objects", delta_sum.stats.sum.num_objects_unfound); - f->dump_unsigned("unfound_total", delta_sum.stats.sum.num_objects); + f->dump_unsigned("unfound_objects", pool_sum.stats.sum.num_objects_unfound); + f->dump_unsigned("unfound_total", pool_sum.stats.sum.num_objects); f->dump_float("unfound_ratio", pc / 100.0); } else { ostringstream ss; - ss << delta_sum.stats.sum.num_objects_unfound - << "/" << delta_sum.stats.sum.num_objects << " objects unfound (" << b << "%)"; + ss << pool_sum.stats.sum.num_objects_unfound + << "/" << pool_sum.stats.sum.num_objects << " objects unfound (" << b << "%)"; psl->push_back(ss.str()); } } diff --git a/src/mon/PGMap.h b/src/mon/PGMap.h index ea43ba3dc41..67c6293da1e 100644 --- a/src/mon/PGMap.h +++ b/src/mon/PGMap.h @@ -99,7 +99,7 @@ public: void print_oneline_summary(Formatter *f, ostream *out) const; void recovery_summary(Formatter *f, list *psl, - const pool_stat_t& delta_sum) const; + const pool_stat_t& pool_sum) const; void overall_recovery_summary(Formatter *f, list *psl) const; void pool_recovery_summary(Formatter *f, list *psl, uint64_t poolid) const; -- 2.39.5