From 74452ad308ce8301edf72a5696cfe735c9cd2da1 Mon Sep 17 00:00:00 2001 From: Venky Shankar Date: Wed, 22 May 2024 06:14:47 -0400 Subject: [PATCH] qa/cephfs: mark file system joinable for fs rename tests before unmounting clients Fixes: http://tracker.ceph.com/issues/66088 Signed-off-by: Venky Shankar --- qa/tasks/cephfs/test_admin.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qa/tasks/cephfs/test_admin.py b/qa/tasks/cephfs/test_admin.py index 18d5ba01bf7..d7d2fd8148d 100644 --- a/qa/tasks/cephfs/test_admin.py +++ b/qa/tasks/cephfs/test_admin.py @@ -839,9 +839,6 @@ class TestRenameCommand(TestAdminCommands): """ That renaming a non-existent file system fails. """ - self.skipTest('This test is broken ATM; see ' - 'https://tracker.ceph.com/issues/66088') - self.run_ceph_cmd(f'fs fail {self.fs.name}') self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session true') sleep(5) @@ -851,6 +848,9 @@ class TestRenameCommand(TestAdminCommands): self.assertEqual(ce.exitstatus, errno.ENOENT, "invalid error code on renaming a non-existent fs") else: self.fail("expected renaming of a non-existent file system to fail") + self.run_ceph_cmd(f'fs set {self.fs.name} joinable true') + self.fs.wait_for_daemons() + self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session false') def test_fs_rename_fails_new_name_already_in_use(self): """ -- 2.39.5