From 74fdebaa6b5c9a4cc460c2a51b2a79c9880e368e Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 5 Jul 2020 23:06:08 +0800 Subject: [PATCH] cmake: append to Seastar_CXX_FLAGS instead of overwriting Seastar_CXX_FLAGS, append to it. this change allows user to set Seastar_CXX_FLAGS in the command line. Signed-off-by: Kefu Chai --- src/CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 054eab5a9be..8d5e64e431e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -331,7 +331,14 @@ if(WITH_SEASTAR) build_dpdk(${CMAKE_BINARY_DIR}/src/dpdk) endif() endif() - set(Seastar_CXX_FLAGS "-Wno-error;-Wno-sign-compare;-Wno-attributes;-Wno-pessimizing-move;-Wno-address-of-packed-member;-Wno-non-virtual-dtor" CACHE STRING "" FORCE) + list(APPEND Seastar_CXX_FLAGS + "-Wno-error" + "-Wno-sign-compare" + "-Wno-attributes" + "-Wno-pessimizing-move" + "-Wno-address-of-packed-member" + "-Wno-non-virtual-dtor") + set(Seastar_CXX_FLAGS "${Seastar_CXX_FLAGS}" CACHE STRING "" FORCE) add_subdirectory(seastar) # create the directory so cmake won't complain when looking at the imported # target: Seastar exports this directory created at build-time -- 2.39.5