From 767564864f15ea8afe9b925345cdf59db1815cb0 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Fri, 24 Sep 2021 12:55:03 +0200 Subject: [PATCH] cephadm: Fix TestMaintenance trying to list /var/lib/ceph Signed-off-by: Sebastian Wagner --- src/cephadm/tests/test_cephadm.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/cephadm/tests/test_cephadm.py b/src/cephadm/tests/test_cephadm.py index 13803f6203c..9a55a9b8344 100644 --- a/src/cephadm/tests/test_cephadm.py +++ b/src/cephadm/tests/test_cephadm.py @@ -940,9 +940,10 @@ class TestMaintenance: with pytest.raises(SystemExit): cd._parse_args(['host-maintenance', 'wah']) + @mock.patch('os.listdir', return_value=[]) @mock.patch('cephadm.call') @mock.patch('cephadm.systemd_target_state') - def test_enter_failure_1(self, _target_state, _call): + def test_enter_failure_1(self, _target_state, _call, _listdir): _call.return_value = '', '', 999 _target_state.return_value = True ctx: cd.CephadmContext = cd.cephadm_init_ctx( @@ -951,9 +952,10 @@ class TestMaintenance: retval = cd.command_maintenance(ctx) assert retval.startswith('failed') + @mock.patch('os.listdir', return_value=[]) @mock.patch('cephadm.call') @mock.patch('cephadm.systemd_target_state') - def test_enter_failure_2(self, _target_state, _call): + def test_enter_failure_2(self, _target_state, _call, _listdir): _call.side_effect = [('', '', 0), ('', '', 999)] _target_state.return_value = True ctx: cd.CephadmContext = cd.cephadm_init_ctx( @@ -962,10 +964,11 @@ class TestMaintenance: retval = cd.command_maintenance(ctx) assert retval.startswith('failed') + @mock.patch('os.listdir', return_value=[]) @mock.patch('cephadm.call') @mock.patch('cephadm.systemd_target_state') @mock.patch('cephadm.target_exists') - def test_exit_failure_1(self, _target_exists, _target_state, _call): + def test_exit_failure_1(self, _target_exists, _target_state, _call, _listdir): _call.return_value = '', '', 999 _target_state.return_value = False _target_exists.return_value = True @@ -975,10 +978,11 @@ class TestMaintenance: retval = cd.command_maintenance(ctx) assert retval.startswith('failed') + @mock.patch('os.listdir', return_value=[]) @mock.patch('cephadm.call') @mock.patch('cephadm.systemd_target_state') @mock.patch('cephadm.target_exists') - def test_exit_failure_2(self, _target_exists, _target_state, _call): + def test_exit_failure_2(self, _target_exists, _target_state, _call, _listdir): _call.side_effect = [('', '', 0), ('', '', 999)] _target_state.return_value = False _target_exists.return_value = True -- 2.39.5