From 76798eabea4d166ef8abd943b78769656a081531 Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Thu, 7 Feb 2013 20:14:34 +0100 Subject: [PATCH] src/osd/OSD.h: use empty() instead of size() Fix warning for usage of *.size(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). warning from cppchecker was: [osd/OSD.h:265]: (performance) Possible inefficient checking for 'last_scrub_pg' emptiness. [osd/OSD.h:274]: (performance) Possible inefficient checking for 'last_scrub_pg' emptiness. Signed-off-by: Danny Al-Gaaf --- src/osd/OSD.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osd/OSD.h b/src/osd/OSD.h index b411c177a36..03d78cc1cd6 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -262,7 +262,7 @@ public: } bool first_scrub_stamp(pair *out) { Mutex::Locker l(sched_scrub_lock); - if (last_scrub_pg.size() == 0) + if (last_scrub_pg.empty()) return false; set< pair >::iterator iter = last_scrub_pg.begin(); *out = *iter; @@ -271,7 +271,7 @@ public: bool next_scrub_stamp(pair next, pair *out) { Mutex::Locker l(sched_scrub_lock); - if (last_scrub_pg.size() == 0) + if (last_scrub_pg.empty()) return false; set< pair >::iterator iter = last_scrub_pg.lower_bound(next); if (iter == last_scrub_pg.end()) -- 2.47.3