From 771648304d7d867e053f8b8fe3ce5b36e061f100 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Fri, 7 Jun 2019 10:50:28 +0200 Subject: [PATCH] validate: fail in check_devices at the right task see https://bugzilla.redhat.com/show_bug.cgi?id=1648168#c17 for details. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1648168#c17 Signed-off-by: Guillaume Abrioux --- roles/ceph-validate/tasks/check_devices.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/roles/ceph-validate/tasks/check_devices.yml b/roles/ceph-validate/tasks/check_devices.yml index d819ca74a..8b3286c5e 100644 --- a/roles/ceph-validate/tasks/check_devices.yml +++ b/roles/ceph-validate/tasks/check_devices.yml @@ -2,15 +2,16 @@ - name: devices validation when: devices is defined block: - - name: validate devices is actually a device + - name: get devices information parted: device: "{{ item }}" unit: MiB register: devices_parted + failed_when: False with_items: "{{ devices }}" - name: fail if one of the devices is not a device fail: msg: "{{ item }} is not a block special file!" - when: item.failed + when: item.rc is defined with_items: "{{ devices_parted.results }}" -- 2.39.5