From 776a3ab14a0a933dfee25b89dc308ff283b8a9ac Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 28 Feb 2021 13:20:41 +0800 Subject: [PATCH] crimson/osd: use finally for capturing this * no need to capture this, it is already enclosed by `ref` * use finally for capturing `ref`, and for printing out the "complete" logging message. we could use a different branch for printing out the failure message if any. Signed-off-by: Kefu Chai --- src/crimson/osd/osd_operations/peering_event.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crimson/osd/osd_operations/peering_event.cc b/src/crimson/osd/osd_operations/peering_event.cc index 2372adb328e..aa3fdec2155 100644 --- a/src/crimson/osd/osd_operations/peering_event.cc +++ b/src/crimson/osd/osd_operations/peering_event.cc @@ -90,8 +90,8 @@ seastar::future<> PeeringEvent::start() } }).then([this] { return shard_services.send_pg_temp(); - }).then([this, ref=std::move(ref)] { - logger().debug("{}: complete", *this); + }).finally([ref=std::move(ref)] { + logger().debug("{}: complete", *ref); }); } -- 2.39.5