From 7779901e5f12e3f3bd59a9ac5d698c904b855dd2 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Sat, 29 Sep 2012 01:17:21 -0700 Subject: [PATCH] mds: add assert to lock path This makes coverity happy: CID 716916: Explicit null dereferenced (FORWARD_NULL) At (28): Passing null pointer "in" to function "MDSCacheObject::state_test(unsigned int) const", which dereferences it. [hide details] Signed-off-by: Sage Weil --- src/mds/Locker.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc index 72802ea7e7c60..a03789f23685a 100644 --- a/src/mds/Locker.cc +++ b/src/mds/Locker.cc @@ -606,6 +606,7 @@ void Locker::eval_gather(SimpleLock *lock, bool first, bool *pneed_issue, listget_parent() << dendl; if (lock->get_sm() == &sm_filelock) { + assert(in); if (in->state_test(CInode::STATE_NEEDSRECOVER)) { dout(7) << "eval_gather finished gather, but need to recover" << dendl; mds->mdcache->queue_file_recover(in); -- 2.39.5