From 796f50b08e1b424d67812d1e7f443618b9059cd9 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Wed, 12 Apr 2023 11:18:15 -0400 Subject: [PATCH] rgw/s3: dump Message field in Error response even if empty some clients like veeam fail to decode the response if Message is missing Fixes: https://tracker.ceph.com/issues/59433 Signed-off-by: Casey Bodley (cherry picked from commit 6de9e376b61fc11be9033a03d027dd0fa7f200ad) --- src/rgw/rgw_common.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rgw/rgw_common.cc b/src/rgw/rgw_common.cc index 3d09a1e001fa4..005d256d5ed5b 100644 --- a/src/rgw/rgw_common.cc +++ b/src/rgw/rgw_common.cc @@ -360,8 +360,7 @@ void dump(struct req_state* s) s->formatter->open_object_section("Error"); if (!s->err.err_code.empty()) s->formatter->dump_string("Code", s->err.err_code); - if (!s->err.message.empty()) - s->formatter->dump_string("Message", s->err.message); + s->formatter->dump_string("Message", s->err.message); if (!s->bucket_name.empty()) // TODO: connect to expose_bucket s->formatter->dump_string("BucketName", s->bucket_name); if (!s->trans_id.empty()) // TODO: connect to expose_bucket or another toggle -- 2.39.5