From 7a1bce2789a3b3aca0ac5640fa7877053e17c0e5 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 1 Apr 2018 20:27:24 +0800 Subject: [PATCH] src: s/--use-wheel// --use-wheel was deprecated in favor of --only-binary in pip v7.0.0. and --use-wheel was removed in a recent release of pip. but some packages are source packages, so we cannot simply replace use-wheel with only-binary. so a simpler approach is to drop --use-wheel option, as pip respects --find-links, and will find the required package from the wheelhouse. Signed-off-by: Kefu Chai (cherry picked from commit a80cce4ba6afee921a7c6adce802c91e30f8c0a9) Conflicts: src/ceph-detect-init/CMakeLists.txt src/ceph-disk/CMakeLists.txt: trivial resolution src/pybind/mgr/dashboard/CMakeLists.txt: dashboard2 is not in luminous, so drop this change. --- src/ceph-detect-init/CMakeLists.txt | 2 +- src/ceph-detect-init/tox.ini | 1 - src/ceph-disk/CMakeLists.txt | 2 +- src/ceph-disk/tox.ini | 1 - src/tools/setup-virtualenv.sh | 4 ++-- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ceph-detect-init/CMakeLists.txt b/src/ceph-detect-init/CMakeLists.txt index 066be4150cda5..3d4aaf36dfbce 100644 --- a/src/ceph-detect-init/CMakeLists.txt +++ b/src/ceph-detect-init/CMakeLists.txt @@ -3,7 +3,7 @@ set(CEPH_DETECT_INIT_VIRTUALENV ${CEPH_BUILD_VIRTUALENV}/ceph-detect-init-virtua add_custom_target(ceph-detect-init COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh ${CEPH_DETECT_INIT_VIRTUALENV} && - ${CEPH_DETECT_INIT_VIRTUALENV}/bin/pip install --no-index --use-wheel --find-links=file:${CMAKE_SOURCE_DIR}/src/ceph-detect-init/wheelhouse -e . + ${CEPH_DETECT_INIT_VIRTUALENV}/bin/pip install --no-index --find-links=file:${CMAKE_SOURCE_DIR}/src/ceph-detect-init/wheelhouse -e . WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src/ceph-detect-init COMMENT "ceph-detect-init is being created") add_dependencies(tests ceph-detect-init) diff --git a/src/ceph-detect-init/tox.ini b/src/ceph-detect-init/tox.ini index dd631a27d8461..54691f78df801 100644 --- a/src/ceph-detect-init/tox.ini +++ b/src/ceph-detect-init/tox.ini @@ -10,7 +10,6 @@ setenv = VIRTUAL_ENV={envdir} usedevelop = true deps = {env:NO_INDEX:} - --use-wheel --find-links=file://{toxinidir}/wheelhouse -r{toxinidir}/requirements.txt -r{toxinidir}/test-requirements.txt diff --git a/src/ceph-disk/CMakeLists.txt b/src/ceph-disk/CMakeLists.txt index 1bce4d416f007..c6bd09a128214 100644 --- a/src/ceph-disk/CMakeLists.txt +++ b/src/ceph-disk/CMakeLists.txt @@ -3,7 +3,7 @@ set(CEPH_DISK_VIRTUALENV ${CEPH_BUILD_VIRTUALENV}/ceph-disk-virtualenv) add_custom_target(ceph-disk COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh ${CEPH_DISK_VIRTUALENV} && - ${CEPH_DISK_VIRTUALENV}/bin/pip install --no-index --use-wheel --find-links=file:${CMAKE_SOURCE_DIR}/src/ceph-disk/wheelhouse -e . + ${CEPH_DISK_VIRTUALENV}/bin/pip install --no-index --find-links=file:${CMAKE_SOURCE_DIR}/src/ceph-disk/wheelhouse -e . WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src/ceph-disk COMMENT "ceph-disk is being created") add_dependencies(tests ceph-disk) diff --git a/src/ceph-disk/tox.ini b/src/ceph-disk/tox.ini index 2f1f19ea8543a..be75a45009cb4 100644 --- a/src/ceph-disk/tox.ini +++ b/src/ceph-disk/tox.ini @@ -10,7 +10,6 @@ setenv = usedevelop = true deps = {env:NO_INDEX:} - --use-wheel --find-links=file://{toxinidir}/wheelhouse -r{toxinidir}/requirements.txt -r{toxinidir}/test-requirements.txt diff --git a/src/tools/setup-virtualenv.sh b/src/tools/setup-virtualenv.sh index c7680b9558b94..d249d49f2a863 100755 --- a/src/tools/setup-virtualenv.sh +++ b/src/tools/setup-virtualenv.sh @@ -44,7 +44,7 @@ if test -d wheelhouse ; then export NO_INDEX=--no-index fi -pip $DISABLE_PIP_VERSION_CHECK --log $DIR/log.txt install $NO_INDEX --use-wheel --find-links=file://$(pwd)/wheelhouse 'tox >=1.9' +pip $DISABLE_PIP_VERSION_CHECK --log $DIR/log.txt install $NO_INDEX --find-links=file://$(pwd)/wheelhouse 'tox >=1.9' if test -f requirements.txt ; then - pip $DISABLE_PIP_VERSION_CHECK --log $DIR/log.txt install $NO_INDEX --use-wheel --find-links=file://$(pwd)/wheelhouse -r requirements.txt + pip $DISABLE_PIP_VERSION_CHECK --log $DIR/log.txt install $NO_INDEX --find-links=file://$(pwd)/wheelhouse -r requirements.txt fi -- 2.39.5