From 7a644813bde1344121b89db990b5f4cfb1e6b12b Mon Sep 17 00:00:00 2001 From: Dongsheng Yang Date: Thu, 24 Mar 2016 02:12:44 -0400 Subject: [PATCH] unittest: add an assert for chain_listxattr. As there is no assert after chain_listxattr(), and memset actual to '\0' immediately, we did not test chain_listxattr() at all. This patch add an assert to do the unittest for chain_listxattr(). Signed-off-by: Dongsheng Yang --- src/test/objectstore/chain_xattr.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/objectstore/chain_xattr.cc b/src/test/objectstore/chain_xattr.cc index 65ab2536db4..83493e016af 100644 --- a/src/test/objectstore/chain_xattr.cc +++ b/src/test/objectstore/chain_xattr.cc @@ -240,6 +240,7 @@ TEST(chain_xattr, listxattr) { char* actual = (char*)calloc(1, buffer_size); ASSERT_LT(buffer_size, chain_listxattr(file, NULL, 0)); // size evaluation is conservative chain_listxattr(file, actual, buffer_size); + ASSERT_EQ(0, ::memcmp(expected, actual, buffer_size)); ::memset(actual, '\0', buffer_size); chain_flistxattr(fd, actual, buffer_size); ASSERT_EQ(0, ::memcmp(expected, actual, buffer_size)); -- 2.39.5