From 7acc2a764f7911663a3f340407a9988fc4c64618 Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Fri, 3 Jul 2020 11:27:19 +0800 Subject: [PATCH] os/bluestore/bluefs: only bytes_written_slow > 0, we update perfcounter. In fact, wrote data into slow devcie is unexpected(see option: bluestore_warn_on_bluefs_spillover). Signed-off-by: Jianpeng Ma --- src/os/bluestore/BlueFS.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc index bc40b66e5fa5e..2f61997696094 100644 --- a/src/os/bluestore/BlueFS.cc +++ b/src/os/bluestore/BlueFS.cc @@ -2886,7 +2886,9 @@ int BlueFS::_flush_range(FileWriter *h, uint64_t offset, uint64_t length) ++p; x_off = 0; } - logger->inc(l_bluefs_bytes_written_slow, bytes_written_slow); + if (bytes_written_slow) { + logger->inc(l_bluefs_bytes_written_slow, bytes_written_slow); + } for (unsigned i = 0; i < MAX_BDEV; ++i) { if (bdev[i]) { if (h->iocv[i] && h->iocv[i]->has_pending_aios()) { -- 2.39.5