From 7f783df2faf2dcffe44b0128ec80d501dcd803d7 Mon Sep 17 00:00:00 2001 From: Eryu Guan Date: Tue, 22 Apr 2014 10:46:17 +1000 Subject: [PATCH] common: set _fs_has_crcs=0 as default in _filter_mkfs() xfsprogs without crc support won't print crc=0/crc=1, so _filter_mkfs() leaves _fs_has_crcs variable unset, and xfs/033 fails because of that. xfs/033 4s ... - output mismatch (see /root/xfstests/results//xfs/033.out.bad) --- tests/xfs/033.out 2014-04-16 22:31:49.818350450 -0400 +++ /root/xfstests/results//xfs/033.out.bad 2014-04-16 22:35:08.264401190 -0400 @@ -5,6 +5,7 @@ naming =VERN bsize=XXX log =LDEV bsize=XXX blocks=XXX realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX +./tests/xfs/033: line 87: [: -eq: unary operator expected Corrupting root inode - setting bits to 0 Wrote X.XXKb (value 0x0) Phase 1 - find and verify superblock... Print _fs_has_crcs=0 to stderr by default, so old xfsprogs could have this variable set too, and a latter _fs_has_crcs=1 could overwrite it if the fs does have crc support. Signed-off-by: Eryu Guan Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner --- common/filter | 1 + 1 file changed, 1 insertion(+) diff --git a/common/filter b/common/filter index a7d2aa93..05dbae6e 100644 --- a/common/filter +++ b/common/filter @@ -143,6 +143,7 @@ _filter_mkfs() return ;; esac + echo "_fs_has_crcs=0" >&2 set - perl -ne ' if (/^meta-data=([\w,|\/.-]+)\s+isize=(\d+)\s+agcount=(\d+), agsize=(\d+) blks/) { -- 2.47.3