From 80ec43792b890fa3aa81d4d5fc89088ca884fde5 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 28 Sep 2019 21:34:06 +0800 Subject: [PATCH] install-deps.sh: only install python-srpm-macros for required macros the reason why we need to install these macros is to solve the egg-chicken problem -- to set `_python_buildid` and `python3_pkgversion` so that we can prepare the build dependencies and install them. in which, `_python_buildid` is defined using `python3_pkgversion`. this macro is offered by python-srpm-macros. the other macros, like `python3_sitelib` and `__python3` are offered by `python3-rpm-macros`. this change also avoid the issue if we install `*rpm-macros` on CentOS8: Error: Problem: package R-rpm-macros-1.1.0-2.el8.noarch requires /usr/bin/Rscript, but none of the providers can be installed - package R-rpm-macros-1.1.0-2.el8.noarch requires R-core, but none of the providers can be installed - conflicting requests - nothing provides libRblas.so()(64bit) needed by R-core-3.6.1-1.el8.x86_64 - nothing provides openblas-Rblas needed by R-core-3.6.1-1.el8.x86_64 (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) Signed-off-by: Kefu Chai --- install-deps.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/install-deps.sh b/install-deps.sh index 18bc62c5f5dc5..cb193366b873f 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -394,7 +394,8 @@ else ;; esac munge_ceph_spec_in $with_seastar $for_make_check $DIR/ceph.spec - $SUDO $yumdnf install -y \*rpm-macros + # for python3_pkgversion + $SUDO $yumdnf install -y python-srpm-macros $SUDO $builddepcmd $DIR/ceph.spec 2>&1 | tee $DIR/yum-builddep.out [ ${PIPESTATUS[0]} -ne 0 ] && exit 1 if [ -n "$dts_ver" ]; then -- 2.39.5