From 814904ae6897b0bf6856bff78cb45f8c45f2e9b5 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Tue, 20 Jun 2017 07:15:53 -0500 Subject: [PATCH] kv/RocksDBStore: default to disable row cache. Signed-off-by: Mark Nelson --- src/common/config_opts.h | 2 +- src/kv/RocksDBStore.cc | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/common/config_opts.h b/src/common/config_opts.h index 709d47658c0..c3626517ab9 100644 --- a/src/common/config_opts.h +++ b/src/common/config_opts.h @@ -970,7 +970,7 @@ OPTION(rocksdb_separate_wal_dir, OPT_BOOL, false) // use $path.wal for wal SAFE_OPTION(rocksdb_db_paths, OPT_STR, "") // path,size( path,size)* OPTION(rocksdb_log_to_ceph_log, OPT_BOOL, true) // log to ceph log OPTION(rocksdb_cache_size, OPT_U64, 128*1024*1024) // default rocksdb cache size -OPTION(rocksdb_cache_row_ratio, OPT_FLOAT, .2) // ratio of cache for row (vs block) +OPTION(rocksdb_cache_row_ratio, OPT_FLOAT, 0) // ratio of cache for row (vs block) OPTION(rocksdb_cache_shard_bits, OPT_INT, 4) // rocksdb block cache shard bits, 4 bit -> 16 shards OPTION(rocksdb_cache_type, OPT_STR, "lru") // 'lru' or 'clock' OPTION(rocksdb_block_size, OPT_INT, 4*1024) // default rocksdb block size diff --git a/src/kv/RocksDBStore.cc b/src/kv/RocksDBStore.cc index 2567e652127..aad274f5c71 100644 --- a/src/kv/RocksDBStore.cc +++ b/src/kv/RocksDBStore.cc @@ -318,7 +318,8 @@ int RocksDBStore::do_open(ostream &out, bool create_if_missing) } bbt_opts.block_size = g_conf->rocksdb_block_size; - opt.row_cache = rocksdb::NewLRUCache(row_cache_size, + if (row_cache_size > 0) + opt.row_cache = rocksdb::NewLRUCache(row_cache_size, g_conf->rocksdb_cache_shard_bits); if (g_conf->kstore_rocksdb_bloom_bits_per_key > 0) { -- 2.39.5